Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-03 22:56:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cecill Etheredge <ijsf@gmx.net>

Browse source 
- The RtlEnumerateGenericTableWithoutSplaying function in RTL (generictable.c) effectively performs an endless enumeration, never advancing to the next successor element in the tree because of a bug in the code. Fix this. (Bug #3756).
- The RtlDelete code misses a line of code checking whether the node is a root,
and instead always returns NULL (assuming it is the root). Fix this. (Bug #3760).
See issue #3760 for more details.

svn path=/trunk/; revision=36663
This commit is contained in:
Aleksey Bragin 2008-10-06 10:50:22 +00:00
parent ef393802e4
commit a7e1400f0c
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
reactos/lib/rtl/generictable.c
View file

@ -390,7 +390,7 @@ RtlEnumerateGenericTableWithoutSplaying(IN PRTL_GENERIC_TABLE Table,
else else
{ {
/* Otherwise, try using the real successor */ /* Otherwise, try using the real successor */
FoundNode = RtlRealSuccessor(Table->TableRoot); FoundNode = RtlRealSuccessor(*RestartKey);
if (FoundNode) *RestartKey = FoundNode; if (FoundNode) *RestartKey = FoundNode;
} }

2
reactos/lib/rtl/splaytree.c
View file

@ -40,7 +40,7 @@ RtlDelete(PRTL_SPLAY_LINKS Links)
if (!(RtlLeftChild(N)) && !(RtlRightChild(N))) if (!(RtlLeftChild(N)) && !(RtlRightChild(N)))
{ {
/* If we are also the root, then the tree is gone */ /* If we are also the root, then the tree is gone */
return NULL; if (RtlIsRoot(N)) return NULL;
/* Get our parent */ /* Get our parent */
P = RtlParent(N); P = RtlParent(N);