From a61379b2fb35e4069aaf1f6ad6fae7de4211399b Mon Sep 17 00:00:00 2001 From: Joachim Henze Date: Tue, 20 Sep 2022 00:24:20 +0200 Subject: [PATCH] [0.4.10][WINHTTP] Fix 1 MSVC2010SP1 x86 dbg warning LNK4199 (#4414) CORE-18104 which I could observe all the way from releases/0.4.7 up to releases/0.4.14 with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuration Creating library dll\win32\winhttp\winhttp.lib and object dll\win32\winhttp\winhttp.exp LINK : warning LNK4199: /DELAYLOAD:ole32.dll ignored; no imports found from ole32.dll Fix picked from 0.4.15-dev-4326-g 2f7dc168f29c0693203cc10901cb6dc4bb23ea75 And just for the record: Wine did the same with their: https://source.winehq.org/git/wine.git/commitdiff/f400f25c2516654f85e0246a4815a2bf62a73cfd --- dll/win32/winhttp/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/win32/winhttp/CMakeLists.txt b/dll/win32/winhttp/CMakeLists.txt index f0c4df8be60..b4eff44908e 100644 --- a/dll/win32/winhttp/CMakeLists.txt +++ b/dll/win32/winhttp/CMakeLists.txt @@ -26,7 +26,7 @@ add_library(winhttp SHARED set_module_type(winhttp win32dll) target_link_libraries(winhttp uuid wine) -add_delay_importlibs(winhttp oleaut32 ole32 crypt32 secur32) +add_delay_importlibs(winhttp oleaut32 crypt32 secur32) add_importlibs(winhttp user32 advapi32 ws2_32 jsproxy msvcrt kernel32 ntdll) add_dependencies(winhttp stdole2) add_pch(winhttp winhttp_private.h SOURCE)