Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 01:55:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

Bring it up to date.

Browse source 
svn path=/trunk/; revision=18350
This commit is contained in:
Brandon Turner 2005-10-08 18:08:17 +00:00
parent 6eb6d65bcc
commit a5ea3f54c1
1 changed files with 26 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
reactos/subsys/system/cmd/todo.txt
View file

@ -1,14 +1,33 @@
Things to do
~~~~~~~~~~~~
Fix bugs :)
*Implmenet Set /P
This is pretty straight forward. When doing this make sure to take into account the way MS handles "set /A /P foo=5" compared to "set /P /A foo=5".
Optimize the code! For size and speed. There are numerous places
where the code is hardly optimal for either.
*Compile as unicode
Not sure what is wrong with it, put probably more then just one thing blocking this. For sure pipes break when it is compiled as unicode.
^S and ^Q to pause/resume displays.
*Move.c code clean up
It works, but it needs to be cleaned up, the code is long and overly complex for what it needs to do. Also, we can remove the hack to cover for MoveFileEx bug as it isnt a bug anymore.
Improve DEL, COPY and MOVE commands.
*If rewrite
It works decent but looks _awful_. Very hard to maintain and/or understand what the hell is going on.
Add wildcard support to REN.
*Decrease Size
MS cmd is 380 kb, and ROS DBG=0 cmd is 404kb! We need to cut down. I think the best way to do this is push a lot of repeated code into misc.c. This is mostly my fault for copying code to all different commands. And i will try to fix this when i get time.
And many, many more...
*Remove Hardcoded buffers
This is mostly done thanks to Greatlord(cmd.c is the hardest spot that is left). ANytime when you are handling a string that is taken from the commandline there should be no limit to the size.
*Implment & and &&
& runs two commands no matter what.
&& runs the 2nd command only if the first was a success
Not sure where to put this code even
*mkdir needs recurvisly create folders
When doing "mkdir c:\windows\foo\bar\foofoo" where foo, bar, and foofoo are not folders, it will create all the folders to that a vaild path
*Correct Error checking
A lot of commands on failure just spit out GetLastError instead of looking for the real cause. It should give a better output to give at least some kinda clue what is wrong.
*Reg Testing
We need more batch files like the one Royce made for "set /a". What out for if bugs when doing this... could lead to in the wrong direction when looking for a regression.