Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-22 16:36:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

[COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093

Browse source 
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147

But greatly eliminates perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.

I committed the same workaround already into 0.4.12-RC-30-g
9513c9bf12

CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de714c

CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476074
This commit is contained in:
Joachim Henze 2019-09-22 21:17:10 +02:00
parent b7f62b9bf9
commit a40331b0f4
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dll/win32/comctl32/button.c
View file

@ -842,6 +842,8 @@ static LRESULT CALLBACK BUTTON_WindowProc(HWND hWnd, UINT uMsg, WPARAM wParam, L
nmhotitem.dwFlags = HICF_ENTERING; nmhotitem.dwFlags = HICF_ENTERING;
SendMessageW(GetParent(hWnd), WM_NOTIFY, nmhotitem.hdr.idFrom, (LPARAM)&nmhotitem); SendMessageW(GetParent(hWnd), WM_NOTIFY, nmhotitem.hdr.idFrom, (LPARAM)&nmhotitem);
theme = GetWindowTheme( hWnd );
if (theme)
InvalidateRect(hWnd, NULL, TRUE); InvalidateRect(hWnd, NULL, TRUE);
} }
@ -896,6 +898,8 @@ static LRESULT CALLBACK BUTTON_WindowProc(HWND hWnd, UINT uMsg, WPARAM wParam, L
nmhotitem.dwFlags = HICF_LEAVING; nmhotitem.dwFlags = HICF_LEAVING;
SendMessageW(GetParent(hWnd), WM_NOTIFY, nmhotitem.hdr.idFrom, (LPARAM)&nmhotitem); SendMessageW(GetParent(hWnd), WM_NOTIFY, nmhotitem.hdr.idFrom, (LPARAM)&nmhotitem);
theme = GetWindowTheme( hWnd );
if (theme)
InvalidateRect(hWnd, NULL, TRUE); InvalidateRect(hWnd, NULL, TRUE);
} }
break; break;