Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-06-28 14:40:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

[MMIXER] Fix NULL dereference CORE-17276

Browse source 
This lead to a crash of winmm:mixer
during "GCCLin_x86 on Test VBox".

The crash was exposed when new code paths
were activated by 0.4.15-dev-791-g
6d7ebc2048

I do intend to port this commit back into 0.4.14RC.
This commit is contained in:
Joachim Henze 2020-09-15 20:54:50 +02:00
parent 0dfc7f06b7
commit a27f0debca
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
sdk/lib/drivers/sound/mmixer/sup.c
View file

@ -690,6 +690,8 @@ MMixerSetGetVolumeControlDetails(
/* get input */ /* get input */
Input = (LPMIXERCONTROLDETAILS_UNSIGNED)MixerControlDetails->paDetails; Input = (LPMIXERCONTROLDETAILS_UNSIGNED)MixerControlDetails->paDetails;
if (!Input)
return MM_STATUS_UNSUCCESSFUL; /* to prevent dereferencing NULL */
if (bSet) if (bSet)
{ {