Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 3/4)

NOTE: Fixing builds ;)

svn path=/trunk/; revision=59510

reactos/base/system/smss/smss.c

@@ -67,7 +67,7 @@ SmpExecuteImage(IN PUNICODE_STRING FileName,
     if (!NT_SUCCESS(Status))
     {
         /* This is a pretty bad failure. ASSERT on checked builds and exit */
-        ASSERTMSG(NT_SUCCESS(Status), "RtlCreateProcessParameters");
+        ASSERTMSG("RtlCreateProcessParameters", NT_SUCCESS(Status));
         DPRINT1("SMSS: RtlCreateProcessParameters failed for %wZ - Status == %lx\n",
                 FileName, Status);
         return Status;

reactos/drivers/bus/pcix/arb/tr_irq.c

@@ -35,7 +35,7 @@ tranirq_Initializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI tranirq_Initializer, unexpected call.");
+    ASSERTMSG("PCI tranirq_Initializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/enum.c

@@ -1127,7 +1127,7 @@ PciSkipThisFunction(IN PPCI_COMMON_HEADER PciData,
         else
         {
             /* Logic error in the driver */
-            ASSERTMSG(FALSE, "PCI Skip Function - Operation type unknown.");
+            ASSERTMSG("PCI Skip Function - Operation type unknown.", FALSE);
         }
 
         /* Check for legacy bridges during resource enumeration */
@@ -2171,7 +2171,7 @@ PciSetResources(IN PPCI_PDO_EXTENSION PdoExtension,
     if (!PcipIsSameDevice(PdoExtension, &PciData))
     {
         /* Fail */
-        ASSERTMSG(FALSE, "PCI Set resources - not same device");
+        ASSERTMSG("PCI Set resources - not same device", FALSE);
         return STATUS_DEVICE_DOES_NOT_EXIST;
     }
 

reactos/drivers/bus/pcix/intrface/agpintrf.c

@@ -35,7 +35,7 @@ agpintrf_Initializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI agpintrf_Initializer, unexpected call.");
+    ASSERTMSG("PCI agpintrf_Initializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/intrface/busintrf.c

@@ -35,7 +35,7 @@ busintrf_Initializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI busintrf_Initializer, unexpected call.");
+    ASSERTMSG("PCI busintrf_Initializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/intrface/cardbus.c

@@ -99,7 +99,7 @@ pcicbintrf_Initializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI pcicbintrf_Initializer, unexpected call.");
+    ASSERTMSG("PCI pcicbintrf_Initializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/intrface/devhere.c

@@ -35,7 +35,7 @@ devpresent_Initializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI devpresent_Initializer, unexpected call.");
+    ASSERTMSG("PCI devpresent_Initializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/intrface/lddintrf.c

@@ -35,7 +35,7 @@ lddintrf_Initializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI lddintrf_Initializer, unexpected call.");
+    ASSERTMSG("PCI lddintrf_Initializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/intrface/locintrf.c

@@ -35,7 +35,7 @@ locintrf_Initializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI locintrf_Initializer, unexpected call.");
+    ASSERTMSG("PCI locintrf_Initializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/intrface/pmeintf.c

@@ -35,7 +35,7 @@ PciPmeInterfaceInitializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI PciPmeInterfaceInitializer, unexpected call.");
+    ASSERTMSG("PCI PciPmeInterfaceInitializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/intrface/routintf.c

@@ -37,7 +37,7 @@ routeintrf_Initializer(IN PVOID Instance)
 {
     UNREFERENCED_PARAMETER(Instance);
     /* PnP Interfaces don't get Initialized */
-    ASSERTMSG(FALSE, "PCI routeintrf_Initializer, unexpected call.");
+    ASSERTMSG("PCI routeintrf_Initializer, unexpected call.", FALSE);
     return STATUS_UNSUCCESSFUL;
 }
 

reactos/drivers/bus/pcix/utils.c

@@ -493,7 +493,7 @@ PciGetDeviceProperty(IN PDEVICE_OBJECT DeviceObject,
                     Status,
                     STATUS_BUFFER_TOO_SMALL);
             *OutputBuffer = NULL;
-            ASSERTMSG(FALSE, "PCI Successfully did the impossible!");
+            ASSERTMSG("PCI Successfully did the impossible!", FALSE);
             break;
         }