Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 10:04:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix Wine Internet Explorer Print hang (#5064)

Browse source 
When using wine internet explorer it crashes if you click print even if you click cancel, this fixes that issue.
nsIWebBrowserPrint_Print apparently causes issues for unknown reasons.

JIRA issue: CORE-16884

By returning S_OK print doesn't cause a crash.
Use ERR and S_OK return before hitting nsIWebBrowserPrint_Print
This commit is contained in:
Doug Lyons 2023-02-12 12:17:55 -06:00 committed by GitHub
parent 3b5d917699
commit a050be0895
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
dll/win32/mshtml/olecmd.c
View file

@ -241,6 +241,13 @@ static HRESULT exec_print(HTMLDocument *This, DWORD nCmdexecopt, VARIANT *pvaIn,
return S_OK; return S_OK;
} }
#ifdef __REACTOS__
// returning here fixes CORE-16884. Maybe use this until printing works.
ERR("Aborting print, to work around CORE-16884\n");
nsIWebBrowserPrint_Release(nsprint);
return S_OK;
#endif
nsres = nsIWebBrowserPrint_GetGlobalPrintSettings(nsprint, &settings); nsres = nsIWebBrowserPrint_GetGlobalPrintSettings(nsprint, &settings);
if(NS_FAILED(nsres)) if(NS_FAILED(nsres))
ERR("GetCurrentPrintSettings failed: %08x\n", nsres); ERR("GetCurrentPrintSettings failed: %08x\n", nsres);