Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-20 04:20:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

Never call IoCompleteRequest while holding a spin lock. Attempting to complete an IRP while holding a spin lock can cause deadlocks.

Browse source 
svn path=/trunk/; revision=27429
This commit is contained in:
Christoph von Wittich 2007-07-06 17:14:24 +00:00
parent f0124e6d34
commit 9f79a749af
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
reactos/drivers/input/kbdclass/kbdclass.c
View file

@ -797,10 +797,10 @@ ClassStartIo(
/* Go to next packet and complete this request */ /* Go to next packet and complete this request */
Irp->IoStatus.Status = Status; Irp->IoStatus.Status = Status;
IoCompleteRequest(Irp, IO_KEYBOARD_INCREMENT);
IoStartNextPacket(DeviceObject, FALSE);
KeReleaseSpinLock(&DeviceExtension->SpinLock, oldIrql); KeReleaseSpinLock(&DeviceExtension->SpinLock, oldIrql);
IoCompleteRequest(Irp, IO_KEYBOARD_INCREMENT);
IoStartNextPacket(DeviceObject, FALSE);
} }
else else
{ {

6
reactos/drivers/input/mouclass/mouclass.c
View file

@ -773,10 +773,10 @@ ClassStartIo(
/* Go to next packet and complete this request */ /* Go to next packet and complete this request */
Irp->IoStatus.Status = Status; Irp->IoStatus.Status = Status;
IoCompleteRequest(Irp, IO_MOUSE_INCREMENT);
IoStartNextPacket(DeviceObject, FALSE);
KeReleaseSpinLock(&DeviceExtension->SpinLock, oldIrql); KeReleaseSpinLock(&DeviceExtension->SpinLock, oldIrql);
IoCompleteRequest(Irp, IO_MOUSE_INCREMENT);
IoStartNextPacket(DeviceObject, FALSE);
} }
else else
{ {