Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-31 19:42:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[MOUNTMGR]

Browse source 
* Properly mark some unreferenced parameters as such.

svn path=/trunk/; revision=59609
This commit is contained in:
Amine Khaldi 2013-08-01 14:29:03 +00:00
parent 2aad33ae32
commit 9d669a5db2
5 changed files with 49 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
reactos/drivers/filters/mountmgr/database.c
View file

@ -298,6 +298,9 @@ DeleteFromLocalDatabaseRoutine(IN PWSTR ValueName,
{
PMOUNTDEV_UNIQUE_ID UniqueId = Context;
UNREFERENCED_PARAMETER(ValueType);
UNREFERENCED_PARAMETER(EntryContext);
/* Ensure it matches, and delete */
if ((UniqueId->UniqueIdLength == ValueLength) &&
(RtlCompareMemory(UniqueId->UniqueId, ValueData, ValueLength) ==
@ -364,6 +367,7 @@ VOID
NTAPI
ReconcileThisDatabaseWithMasterWorker(IN PVOID Parameter)
{
UNREFERENCED_PARAMETER(Parameter);
return;
}
@ -386,6 +390,8 @@ WorkerThread(IN PDEVICE_OBJECT DeviceObject,
PDEVICE_EXTENSION DeviceExtension;
OBJECT_ATTRIBUTES ObjectAttributes;
UNREFERENCED_PARAMETER(DeviceObject);
InitializeObjectAttributes(&ObjectAttributes,
&SafeVolumes,
OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE,
@ -509,6 +515,8 @@ QueryVolumeName(IN HANDLE RootDirectory,
PFILE_NAME_INFORMATION FileNameInfo;
PREPARSE_DATA_BUFFER ReparseDataBuffer;
UNREFERENCED_PARAMETER(ReparsePointInformation);
if (!FileName)
{
InitializeObjectAttributes(&ObjectAttributes,
@ -902,6 +910,8 @@ MigrateRemoteDatabaseWorker(IN PDEVICE_OBJECT DeviceObject,
OBJECT_ATTRIBUTES ObjectAttributes, MigrateAttributes;
#define TEMP_BUFFER_SIZE 0x200
UNREFERENCED_PARAMETER(DeviceObject);
/* Extract context */
WorkItem = Context;
DeviceInformation = WorkItem->DeviceInformation;
@ -1220,6 +1230,10 @@ QueryUniqueIdQueryRoutine(IN PWSTR ValueName,
PMOUNTDEV_UNIQUE_ID IntUniqueId;
PMOUNTDEV_UNIQUE_ID * UniqueId;
UNREFERENCED_PARAMETER(ValueName);
UNREFERENCED_PARAMETER(ValueType);
UNREFERENCED_PARAMETER(EntryContext);
/* Sanity check */
if (ValueLength >= 0x10000)
{
@ -1464,6 +1478,8 @@ DeleteDriveLetterRoutine(IN PWSTR ValueName,
PMOUNTDEV_UNIQUE_ID UniqueId;
UNICODE_STRING RegistryEntry;
UNREFERENCED_PARAMETER(EntryContext);
if (ValueType != REG_BINARY)
{
return STATUS_SUCCESS;
@ -1527,6 +1543,8 @@ DeleteNoDriveLetterEntryRoutine(IN PWSTR ValueName,
{
PMOUNTDEV_UNIQUE_ID UniqueId = Context;
UNREFERENCED_PARAMETER(EntryContext);
/* Ensure we have correct input */
if (ValueName[0] != L'#' || ValueType != REG_BINARY ||
UniqueId->UniqueIdLength != ValueLength)

16
reactos/drivers/filters/mountmgr/device.c
View file

@ -292,6 +292,8 @@ MountMgrCheckUnprocessedVolumes(IN PDEVICE_EXTENSION DeviceExtension,
PDEVICE_INFORMATION DeviceInformation;
NTSTATUS ArrivalStatus, Status = STATUS_SUCCESS;
UNREFERENCED_PARAMETER(Irp);
/* No offline volumes, nothing more to do */
if (IsListEmpty(&(DeviceExtension->OfflineDeviceListHead)))
{
@ -690,6 +692,10 @@ MountMgrQuerySystemVolumeNameQueryRoutine(IN PWSTR ValueName,
UNICODE_STRING ValueString;
PUNICODE_STRING SystemVolumeName;
UNREFERENCED_PARAMETER(ValueName);
UNREFERENCED_PARAMETER(ValueLength);
UNREFERENCED_PARAMETER(EntryContext);
if (ValueType != REG_SZ)
{
return STATUS_SUCCESS;
@ -819,6 +825,8 @@ NTSTATUS
MountMgrQueryDosVolumePath(IN PDEVICE_EXTENSION DeviceExtension,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceExtension);
UNREFERENCED_PARAMETER(Irp);
return STATUS_NOT_IMPLEMENTED;
}
@ -826,6 +834,8 @@ NTSTATUS
MountMgrQueryDosVolumePaths(IN PDEVICE_EXTENSION DeviceExtension,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceExtension);
UNREFERENCED_PARAMETER(Irp);
return STATUS_NOT_IMPLEMENTED;
}
@ -1460,6 +1470,9 @@ MountMgrVolumeMountPointCreated(IN PDEVICE_EXTENSION DeviceExtension,
IN PIRP Irp,
IN NTSTATUS LockStatus)
{
UNREFERENCED_PARAMETER(DeviceExtension);
UNREFERENCED_PARAMETER(Irp);
UNREFERENCED_PARAMETER(LockStatus);
return STATUS_NOT_IMPLEMENTED;
}
@ -1468,6 +1481,9 @@ MountMgrVolumeMountPointDeleted(IN PDEVICE_EXTENSION DeviceExtension,
IN PIRP Irp,
IN NTSTATUS LockStatus)
{
UNREFERENCED_PARAMETER(DeviceExtension);
UNREFERENCED_PARAMETER(Irp);
UNREFERENCED_PARAMETER(LockStatus);
return STATUS_NOT_IMPLEMENTED;
}

6
reactos/drivers/filters/mountmgr/mountmgr.c
View file

@ -816,6 +816,8 @@ MountMgrUnload(IN struct _DRIVER_OBJECT *DriverObject)
PDEVICE_INFORMATION DeviceInformation;
PSAVED_LINK_INFORMATION SavedLinkInformation;
UNREFERENCED_PARAMETER(DriverObject);
/* Don't get notification any longer */
IoUnregisterShutdownNotification(gdeviceObject);
@ -1663,6 +1665,8 @@ MountMgrCreateClose(IN PDEVICE_OBJECT DeviceObject,
PIO_STACK_LOCATION Stack;
NTSTATUS Status = STATUS_SUCCESS;
UNREFERENCED_PARAMETER(DeviceObject);
Stack = IoGetCurrentIrpStackLocation(Irp);
/* Allow driver opening for communication
@ -1688,6 +1692,8 @@ NTAPI
MountMgrCancel(IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceObject);
RemoveEntryList(&(Irp->Tail.Overlay.ListEntry));
IoReleaseCancelSpinLock(Irp->CancelIrql);

5
reactos/drivers/filters/mountmgr/notify.c
View file

@ -511,6 +511,8 @@ UniqueIdChangeNotifyWorker(IN PDEVICE_OBJECT DeviceObject,
PMOUNTDEV_UNIQUE_ID OldUniqueId, NewUniqueId;
PMOUNTDEV_UNIQUE_ID_CHANGE_NOTIFY_OUTPUT UniqueIdChange;
UNREFERENCED_PARAMETER(DeviceObject);
/* Validate worker */
if (!NT_SUCCESS(WorkItem->Irp->IoStatus.Status))
{
@ -567,6 +569,9 @@ UniqueIdChangeNotifyCompletion(IN PDEVICE_OBJECT DeviceObject,
{
PUNIQUE_ID_WORK_ITEM WorkItem = Context;
UNREFERENCED_PARAMETER(DeviceObject);
UNREFERENCED_PARAMETER(Irp);
/* Simply queue the work item */
IoQueueWorkItem(WorkItem->WorkItem,
UniqueIdChangeNotifyWorker,

4
reactos/drivers/filters/mountmgr/symlink.c
View file

@ -119,6 +119,8 @@ GlobalCreateSymbolicLink(IN PUNICODE_STRING DosName,
NTSTATUS Status;
UNICODE_STRING GlobalName;
UNREFERENCED_PARAMETER(DeviceName);
/* First create the global string */
Status = CreateStringWithGlobal(DosName, &GlobalName);
if (!NT_SUCCESS(Status))
@ -529,6 +531,8 @@ QuerySymbolicLinkNamesFromStorage(IN PDEVICE_EXTENSION DeviceExtension,
BOOLEAN WriteNew;
RTL_QUERY_REGISTRY_TABLE QueryTable[2];
UNREFERENCED_PARAMETER(DeviceExtension);
/* First of all, count links */
RtlZeroMemory(QueryTable, sizeof(QueryTable));
QueryTable[0].QueryRoutine = SymbolicLinkNamesFromUniqueIdCount;