Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-28 19:32:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

[BROWSEUI_APITEST] Don't hardcode C:\Windows (#7634)

Browse source 
Avoid hardcoding and fix tests.
JIRA issue: CORE-13235
- Remove hardcoded "C:\\Windows\\system32",
  using GetSystemDirectoryW call in
  SHExplorerParseCmdLine testcase.
This commit is contained in:
Katayama Hirofumi MZ 2025-01-18 22:58:05 +09:00 committed by GitHub
parent 82b7d4f3da
commit 9d1c0efb1f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
modules/rostests/apitests/browseui/SHExplorerParseCmdLine.c
View file

@ -260,8 +260,28 @@ _Out_opt_ PUINT PWriteEnd)
}
}
static WCHAR s_szSystem32[MAX_PATH];
static WCHAR s_szDriveCSelectSystem32[MAX_PATH];
static WCHAR s_szSlashSelectSystem32[MAX_PATH];
static WCHAR s_szEqualSlashSelectSystem32[MAX_PATH];
START_TEST(SHExplorerParseCmdLine)
{
// "C:\\Windows\\system32"
GetSystemDirectoryW(s_szSystem32, _countof(s_szSystem32));
// "c:\\=/select=c:\\windows\\system32"
StringCchCopyW(s_szDriveCSelectSystem32, _countof(s_szDriveCSelectSystem32), L"c:\\=/select=");
StringCchCatW(s_szDriveCSelectSystem32, _countof(s_szDriveCSelectSystem32), s_szSystem32);
// "/select=c:\\windows\\system32"
StringCchCopyW(s_szSlashSelectSystem32, _countof(s_szSlashSelectSystem32), L"/select=");
StringCchCatW(s_szSlashSelectSystem32, _countof(s_szSlashSelectSystem32), s_szSystem32);
// "=/select=c:\\windows\\system32"
StringCchCopyW(s_szEqualSlashSelectSystem32, _countof(s_szEqualSlashSelectSystem32), L"=/select=");
StringCchCatW(s_szEqualSlashSelectSystem32, _countof(s_szEqualSlashSelectSystem32), s_szSystem32);
static struct
{
INT TestLine;
@ -390,9 +410,9 @@ START_TEST(SHExplorerParseCmdLine)
{ __LINE__, L"/select=c:\\Program files", TRUE, PIDL_IS_PATH, 0x00000200, NULL, L"C:\\Program Files" },
{ __LINE__, L"=,/select,c:\\", TRUE, PIDL_IS_PATH, 0x00000240, NULL, L"C:\\" },
{ __LINE__, L"/select,c:\\,=", TRUE, CSIDL_DRIVES, 0x00000240 },
{ __LINE__, L"c:\\=/select=c:\\windows\\system32", TRUE, PIDL_IS_PATH, 0x00000240, NULL, L"C:\\WINDOWS\\system32" },
{ __LINE__, L"/select=c:\\windows\\system32", TRUE, PIDL_IS_PATH, 0x00000200, NULL, L"C:\\WINDOWS\\system32" },
{ __LINE__, L"=/select=c:\\windows\\system32", TRUE, PIDL_IS_PATH, 0x00000240, NULL, L"C:\\WINDOWS\\system32" },
{ __LINE__, s_szDriveCSelectSystem32, TRUE, PIDL_IS_PATH, 0x00000240, NULL, s_szSystem32 },
{ __LINE__, s_szSlashSelectSystem32, TRUE, PIDL_IS_PATH, 0x00000200, NULL, s_szSystem32 },
{ __LINE__, s_szEqualSlashSelectSystem32, TRUE, PIDL_IS_PATH, 0x00000240, NULL, s_szSystem32 },
{ __LINE__, L"/e,=", TRUE, CSIDL_DRIVES, 0x00000208 },
{ __LINE__, L"/e=", TRUE, CSIDL_DRIVES, 0x00000200 },
{ __LINE__, L"/e=\"", TRUE, CSIDL_DRIVES, 0x00000200 },