From 9cd60c528845bf393332afe7757adad99261d3b5 Mon Sep 17 00:00:00 2001 From: winesync Date: Fri, 5 Jan 2024 16:49:06 +0100 Subject: [PATCH] [WINESYNC] setupapi: Fix buffer overflow in SetupGetFileCompressionInfoW. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit wine commit id b8c42020a98e3a5f486cbd03ef80302d6d605871 by Thomas Faber SYNC NOTE: Already in ReactOS but reformatted following Wine. See commit dcb9fa585 (r58019) Co-authored-by: Hermès Bélusca-Maïto --- dll/win32/setupapi/misc.c | 3 ++- sdk/tools/winesync/setupapi.cfg | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dll/win32/setupapi/misc.c b/dll/win32/setupapi/misc.c index f5dee239d96..fa641680d0f 100644 --- a/dll/win32/setupapi/misc.c +++ b/dll/win32/setupapi/misc.c @@ -1579,7 +1579,8 @@ DWORD WINAPI SetupGetFileCompressionInfoW( PCWSTR source, PWSTR *name, PDWORD so return ERROR_INVALID_PARAMETER; ret = SetupGetFileCompressionInfoExW( source, NULL, 0, &required, NULL, NULL, NULL ); - if (!(actual_name = MyMalloc( required*sizeof(WCHAR) ))) return ERROR_NOT_ENOUGH_MEMORY; + if (!(actual_name = MyMalloc( required * sizeof(WCHAR) ))) + return ERROR_NOT_ENOUGH_MEMORY; ret = SetupGetFileCompressionInfoExW( source, actual_name, required, &required, source_size, target_size, type ); diff --git a/sdk/tools/winesync/setupapi.cfg b/sdk/tools/winesync/setupapi.cfg index 295d65e35bf..df809858d67 100644 --- a/sdk/tools/winesync/setupapi.cfg +++ b/sdk/tools/winesync/setupapi.cfg @@ -5,4 +5,4 @@ files: dlls/setupapi/misc.c: dll/win32/setupapi/misc.c dlls/setupapi/stubs.c: dll/win32/setupapi/stubs.c tags: - wine: 8d854a4830776aaacb70161709db315d54eb77f0 + wine: b8c42020a98e3a5f486cbd03ef80302d6d605871