Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-24 03:24:45 +00:00
Code Issues Projects Releases Packages Wiki Activity

[RTL][KERNEL32] Add a comment indicating we need SEH in RtlImageNtHeaderEx

Browse source 
CORE-14532
CORE-14857
This commit is contained in:
Mark Jansen 2018-07-29 19:45:13 +02:00
parent ad08c6631b
commit 9b6fb9f2f8
No known key found for this signature in database
GPG key ID: B39240EE84BEAE8B
3 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
dll/win32/kernel32/client/loader.c
View file

@ -463,6 +463,7 @@ FreeLibrary(HINSTANCE hLibModule)
if (LDR_IS_DATAFILE(hLibModule)) if (LDR_IS_DATAFILE(hLibModule))
{ {
// FIXME: This SEH should go inside RtlImageNtHeader instead // FIXME: This SEH should go inside RtlImageNtHeader instead
// See https://jira.reactos.org/browse/CORE-14857
_SEH2_TRY _SEH2_TRY
{ {
/* This is a LOAD_LIBRARY_AS_DATAFILE module, check if it's a valid one */ /* This is a LOAD_LIBRARY_AS_DATAFILE module, check if it's a valid one */

2
modules/rostests/apitests/ntdll/load_notifications.c
View file

@ -72,7 +72,7 @@ BOOL WINAPI notify_DllMain(IN HINSTANCE hDllHandle, IN DWORD dwReason, IN LPVOID
} }
else else
{ {
ok_int(handlers, g_DLL_DETACH); ok_int(handlers, g_DLL_DETACH); // For failures, see https://jira.reactos.org/browse/CORE-14857
} }
if (InterlockedCompareExchange(&g_DllMainExcept, 0xffffff, dwReason) == dwReason) if (InterlockedCompareExchange(&g_DllMainExcept, 0xffffff, dwReason) == dwReason)

1
sdk/lib/rtl/image.c
View file

@ -134,6 +134,7 @@ LdrVerifyMappedImageMatchesChecksum(
/* /*
* @implemented * @implemented
* @note This needs SEH (See https://jira.reactos.org/browse/CORE-14857)
*/ */
NTSTATUS NTSTATUS
NTAPI NTAPI