[ROSAPPS] Fix GCC8 warnings

modules/rosapps/applications/devutils/createspec/CMakeLists.txt

@@ -1,4 +1,8 @@
 
+if(GCC AND GCC_VERSION VERSION_GREATER 7)
+    add_compile_flags("-Wno-stringop-overflow")
+endif()
+
 add_executable(createspec createspec.c)
 set_module_type(createspec win32cui)
 target_link_libraries(createspec wine)

modules/rosapps/applications/devutils/vgafontedit/fontboxeswnd.c

@@ -30,13 +30,6 @@ GetCharacterRect(IN UINT uFontRow, IN UINT uFontColumn, OUT LPRECT CharacterRect
     CharacterRect->bottom = CharacterRect->top + CHARACTER_BOX_HEIGHT;
 }
 
-__inline VOID
-GetCharacterPosition(IN UINT uCharacter, OUT PUINT uFontRow, OUT PUINT uFontColumn)
-{
-    *uFontRow = uCharacter / 16;
-    *uFontColumn = uCharacter % 16;
-}
-
 static INT
 FontBoxesHitTest(IN UINT xPos, IN UINT yPos, OUT LPRECT CharacterRect)
 {

modules/rosapps/applications/devutils/vgafontedit/precomp.h

@@ -136,9 +136,14 @@ VOID CreateFontBoxesWindow(PFONT_WND_INFO FontWndInfo);
 BOOL InitFontBoxesWndClass(VOID);
 VOID UnInitFontBoxesWndClass(VOID);
 VOID GetCharacterRect(IN UINT uFontRow, IN UINT uFontColumn, OUT LPRECT CharacterRect);
-__inline VOID GetCharacterPosition(IN UINT uCharacter, OUT PUINT uFontRow, OUT PUINT uFontColumn);
 VOID EditCurrentGlyph(PFONT_WND_INFO FontWndInfo);
 
+inline VOID GetCharacterPosition(IN UINT uCharacter, OUT PUINT uFontRow, OUT PUINT uFontColumn)
+{
+    *uFontRow = uCharacter / 16;
+    *uFontColumn = uCharacter % 16;
+}
+
 // fontwnd.c
 BOOL CreateFontWindow(PMAIN_WND_INFO MainWndInfo, PFONT_OPEN_INFO OpenInfo);
 BOOL InitFontWndClass(VOID);

modules/rosapps/applications/net/ncftp/ncftp/progress.c

@@ -209,7 +209,7 @@ PrStatBar(const FTPCIPtr cip, int mode)
 	static double uTotal, uMult;
 	const char *stall;
 	char localName[80];
-	char line[128];
+	char line[134];
 	int i;
 
 	switch (mode) {

modules/rosapps/applications/net/roshttpd/config.cpp

@@ -49,7 +49,7 @@ void CConfig::Default()
 	try {
 		lpsStr = _strdup(dcfgDefaultResource);
 		DefaultResources.Insert(lpsStr);
-	} catch (bad_alloc e) {
+	} catch (bad_alloc&) {
 		free((void *)lpsStr);
 		Clear();
 		throw;

modules/rosapps/applications/net/roshttpd/httpd.cpp

@@ -486,7 +486,7 @@ VOID CHttpDaemonThread::Execute()
 		delete Daemon;
 	} catch (ESocket e) {
 		ReportErrorStr(e.what());
-	} catch	(bad_alloc e) {
+	} catch	(bad_alloc&) {
 		ReportErrorStr(TS("Insufficient resources."));
 	}
 }

modules/rosapps/applications/net/roshttpd/roshttpd.cpp

@@ -45,7 +45,7 @@ VOID Run()
 
 		if (pConfiguration != NULL)
 		    delete pConfiguration;
-	} catch (bad_alloc e) {
+	} catch (bad_alloc&) {
 		if (pConfiguration != NULL)
 			delete pConfiguration;
 		ReportErrorStr(TS("Insufficient resources."));

modules/rosapps/applications/sysutils/man/man.c

@@ -155,9 +155,9 @@ void text_outp(char *cur_string)
         while(cur_string[symbol]!=' ')
             symbol++;
 
-
     for(;cur_string[symbol]!='\n'; symbol++)
         putchar(cur_string[symbol]);
+
     putchar(' ');
 }
 
@@ -214,12 +214,15 @@ AnalyzeFile()
         putchar(' ');
        }
 
-     else text_outp(cur_string); // print plane text
+     else
+     {
+       text_outp(cur_string); // print plane text
+     }
     th_outp(cur_string, THtag);
-/* END of TAGs processing */
+    /* END of TAGs processing */
+
     free(cur_string);
     free(THtag);
-
     return 0;
 }
 

modules/rosapps/applications/sysutils/regexpl/Console.cpp

@@ -716,7 +716,9 @@ Paste:
 				ASSERT(dwCompletionOffset <= dwCurrentCharOffset);
 
         // Save not changing part (context) of completion in m_pchBuffer1
-				_tcsncpy(m_pchBuffer1,m_pchBuffer,dwCompletionOffset);
+
+				// FIXME: dwCompletionOffset is always 0 here
+				// _tcsncpy(m_pchBuffer1,m_pchBuffer,dwCompletionOffset);
 				m_pchBuffer1[dwCompletionOffset] = 0;
 
         // Size of changing part

modules/rosapps/applications/sysutils/screenshot/screenshot.c

@@ -273,13 +273,17 @@ ConvertDDBtoDIB(PSCREENSHOT pScrSht)
 	else cClrBits = 32;
 
   if (cClrBits != 24)
+  {
     pScrSht->lpbi = (PBITMAPINFO) HeapAlloc(GetProcessHeap(),
                                             0,
                                             sizeof(BITMAPINFOHEADER) + sizeof(RGBQUAD) * (1 << cClrBits));
+  }
   else
+  {
     pScrSht->lpbi = (PBITMAPINFO) HeapAlloc(GetProcessHeap(),
                                             0,
                                             sizeof(BITMAPINFOHEADER));
+  }
 
 	if (!pScrSht->lpbi)
 	{