Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-03 15:36:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTFS]

Browse source 
Don't leak memory in case of failures in NtfsReadDisk().

Based on a patch by Trevor Thompson.

CORE-10998

svn path=/trunk/; revision=71155
This commit is contained in:
Pierre Schweitzer 2016-04-13 19:52:42 +00:00
parent 278ccfd7c8
commit 97d46bb600
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
reactos/drivers/filesystems/ntfs/blockdev.c
View file

@ -87,6 +87,12 @@ NtfsReadDisk(IN PDEVICE_OBJECT DeviceObject,
if (Irp == NULL) if (Irp == NULL)
{ {
DPRINT("IoBuildSynchronousFsdRequest failed\n"); DPRINT("IoBuildSynchronousFsdRequest failed\n");
if (AllocatedBuffer)
{
ExFreePoolWithTag(ReadBuffer, TAG_NTFS);
}
return STATUS_INSUFFICIENT_RESOURCES; return STATUS_INSUFFICIENT_RESOURCES;
} }
@ -108,9 +114,13 @@ NtfsReadDisk(IN PDEVICE_OBJECT DeviceObject,
Status = IoStatus.Status; Status = IoStatus.Status;
} }
if (NT_SUCCESS(Status) && AllocatedBuffer) if (AllocatedBuffer)
{ {
RtlCopyMemory(Buffer, ReadBuffer + (StartingOffset - RealReadOffset), Length); if (NT_SUCCESS(Status))
{
RtlCopyMemory(Buffer, ReadBuffer + (StartingOffset - RealReadOffset), Length);
}
ExFreePoolWithTag(ReadBuffer, TAG_NTFS); ExFreePoolWithTag(ReadBuffer, TAG_NTFS);
} }