Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-08 11:24:14 +00:00
Code Issues Projects Releases Packages Wiki Activity

[DEVMGR] Avoid buffer overflow when device reg key size is > 100 chars

Browse source
This commit is contained in:
Victor Perevertkin 2020-10-22 14:38:55 +03:00
parent bbe47e61b1
commit 953c03c336
No known key found for this signature in database
GPG key ID: C750B7222E9C7830
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
dll/win32/devmgr/properties/hwresource.cpp
View file

@ -357,13 +357,15 @@ PVOID
GetResourceList( GetResourceList(
LPWSTR pszDeviceID) LPWSTR pszDeviceID)
{ {
WCHAR szBuffer[100];
PCM_RESOURCE_LIST pResourceList = NULL; PCM_RESOURCE_LIST pResourceList = NULL;
HKEY hKey = NULL; HKEY hKey = NULL;
DWORD dwError, dwSize; DWORD dwError, dwSize;
wsprintf(szBuffer, L"SYSTEM\\CurrentControlSet\\Enum\\%s\\LogConf", pszDeviceID); CStringW keyName = L"SYSTEM\\CurrentControlSet\\Enum\\";
dwError = RegOpenKeyExW(HKEY_LOCAL_MACHINE, szBuffer, 0, KEY_READ, &hKey); keyName += pszDeviceID;
keyName += L"\\LogConf";
dwError = RegOpenKeyExW(HKEY_LOCAL_MACHINE, keyName, 0, KEY_READ, &hKey);
if (dwError != ERROR_SUCCESS) if (dwError != ERROR_SUCCESS)
{ {
/* failed to open device instance log conf dir */ /* failed to open device instance log conf dir */