From 9539538ba0d4bbfdc6f2749ddd0ba37090ea7f83 Mon Sep 17 00:00:00 2001 From: Johannes Anderwald Date: Fri, 9 May 2008 18:11:40 +0000 Subject: [PATCH] - when menu position cannot be found insert new item at the end - reduces winetest failures from 1550 to 1250 - behaviour verified on Windows Vista svn path=/trunk/; revision=33400 --- reactos/subsystems/win32/win32k/ntuser/menu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/reactos/subsystems/win32/win32k/ntuser/menu.c b/reactos/subsystems/win32/win32k/ntuser/menu.c index c7f0f124bc5..1bd8d2fc7a9 100644 --- a/reactos/subsystems/win32/win32k/ntuser/menu.c +++ b/reactos/subsystems/win32/win32k/ntuser/menu.c @@ -953,8 +953,9 @@ IntInsertMenuItem(PMENU_OBJECT MenuObject, UINT uItem, BOOL fByPosition, } if (SubMenu == NULL) { - SetLastWin32Error(ERROR_INVALID_PARAMETER); - return FALSE; + /* default to last position of menu */ + SubMenu = MenuObject; + pos = MenuObject->MenuInfo.MenuItemCount; }