Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-06 09:33:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

[IPHLPAPI] Check pointers when returning module info from specific connection

Browse source
This commit is contained in:
Pierre Schweitzer 2019-02-16 09:00:06 +01:00
parent 22f60faf43
commit 93b0957641
No known key found for this signature in database
GPG key ID: 7545556C3D585B0B
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
dll/win32/iphlpapi/iphlpapi_main.c
View file

@ -2293,6 +2293,12 @@ static DWORD GetOwnerModuleFromPidEntry(DWORD OwningPid, TCPIP_OWNER_MODULE_INFO
WCHAR File[MAX_PATH], Path[MAX_PATH]; WCHAR File[MAX_PATH], Path[MAX_PATH];
PTCPIP_OWNER_MODULE_BASIC_INFO BasicInfo; PTCPIP_OWNER_MODULE_BASIC_INFO BasicInfo;
if (IsBadWritePtr(pdwSize, sizeof(DWORD)) ||
IsBadWritePtr(Buffer, *pdwSize))
{
return ERROR_INVALID_PARAMETER;
}
if (OwningPid == 0) if (OwningPid == 0)
{ {
return ERROR_NOT_FOUND; return ERROR_NOT_FOUND;
@ -2363,6 +2369,12 @@ static DWORD GetOwnerModuleFromTagEntry(DWORD OwningPid, DWORD OwningTag, TCPIP_
PWSTR Buffer; PWSTR Buffer;
} ServiceQuery; } ServiceQuery;
if (IsBadWritePtr(pdwSize, sizeof(DWORD)) ||
IsBadWritePtr(Buffer, *pdwSize))
{
return ERROR_INVALID_PARAMETER;
}
/* First, secure (avoid injections) load advapi32.dll */ /* First, secure (avoid injections) load advapi32.dll */
Size = GetSystemDirectoryW(SysDir, MAX_PATH); Size = GetSystemDirectoryW(SysDir, MAX_PATH);
if (Size == 0) if (Size == 0)