[VGA_NEW]

- avoid buffer overrun, CID 11049
Brought to light by vicmarcal

svn path=/trunk/; revision=50085

reactos/drivers/video/miniport/vga_new/vbe.c

@@ -91,7 +91,7 @@ ValidateVbeInfo(IN PHW_DEVICE_EXTENSION VgaExtension,
     Context = VgaExtension->Int10Interface.Context;
 
     /* Check magic and version */
-    if (strncmp(VbeInfo->Info.Signature, "VESA", 4)) return VesaBiosOk;
+    if (VbeInfo->Info.Signature == VESA_MAGIC) return VesaBiosOk;
     if (VbeInfo->Info.Version < 0x102) return VesaBiosOk;
 
     /* Read strings */

reactos/drivers/video/miniport/vga_new/vbe.h

@@ -94,7 +94,7 @@
 
 typedef struct _VBE_CONTROLLER_INFO
 {
-   CHAR Signature[4];
+   ULONG Signature;
    USHORT Version;
    ULONG OemStringPtr;
    LONG Capabilities;
@@ -214,4 +214,7 @@ ValidateVbeInfo(IN PHW_DEVICE_EXTENSION VgaExtension,
 
 extern BOOLEAN g_bIntelBrookdaleBIOS;
 
+/* VBE2 magic number */
+#define VBE2_MAGIC ('V' + ('B' << 8) + ('E' << 16) + ('2' << 24))
+
 /* EOF */

reactos/drivers/video/miniport/vga_new/vbemodes.c

@@ -209,7 +209,7 @@ InitializeModeTable(IN PHW_DEVICE_EXTENSION VgaExtension)
     /* Init VBE data and write to card buffer */
     //VideoPortDebugPrint(0, "have int10 data\n");
     VbeInfo->ModeArray[128] = 0xFFFF;
-    strcpy(VbeInfo->Info.Signature, "VBE2");
+    VbeInfo->Info.Signature = VBE2_MAGIC;
     Status = VgaExtension->Int10Interface.Int10WriteMemory(Context,
                                                            TrampolineMemorySegment,
                                                            TrampolineMemoryOffset,

reactos/drivers/video/miniport/vga_new/vga.h

@@ -443,4 +443,7 @@ extern PVIDEOMODE VgaModeList;
 // eVb: 3.5 [END]
 extern VIDEO_ACCESS_RANGE VgaAccessRange[];
 
+/* VESA Bios Magic number */
+#define VESA_MAGIC ('V' + ('E' << 8) + ('S' << 16) + ('A' << 24))
+
 #include "vbe.h"