From 8c1bafc6f8bec3d4260681813517f774a19b1694 Mon Sep 17 00:00:00 2001 From: David Quintana Date: Tue, 20 May 2014 09:09:08 +0000 Subject: [PATCH] [BROWSEUI] * Fix a couple redundant IFs. CORE-8248 #resolve #comment Thanks for reporting. svn path=/branches/shell-experiments/; revision=63381 --- dll/win32/browseui/addressband.cpp | 3 +-- dll/win32/browseui/addresseditbox.cpp | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dll/win32/browseui/addressband.cpp b/dll/win32/browseui/addressband.cpp index d4f9892a157..2f5ef7ca591 100644 --- a/dll/win32/browseui/addressband.cpp +++ b/dll/win32/browseui/addressband.cpp @@ -217,8 +217,7 @@ HRESULT STDMETHODCALLTYPE CAddressBand::SetSite(IUnknown *pUnkSite) hResult = IUnknown_QueryService(pUnkSite, SID_SShellBrowser, IID_PPV_ARG(IBrowserService, &browserService)); if (SUCCEEDED(hResult)) { - if (SUCCEEDED(hResult)) - hResult = AtlAdvise(browserService, static_cast(this), DIID_DWebBrowserEvents, &fAdviseCookie); + hResult = AtlAdvise(browserService, static_cast(this), DIID_DWebBrowserEvents, &fAdviseCookie); } return hResult; diff --git a/dll/win32/browseui/addresseditbox.cpp b/dll/win32/browseui/addresseditbox.cpp index 72643454b54..90a4b194a59 100644 --- a/dll/win32/browseui/addresseditbox.cpp +++ b/dll/win32/browseui/addresseditbox.cpp @@ -78,8 +78,7 @@ HRESULT STDMETHODCALLTYPE CAddressEditBox::Init(HWND comboboxEx, HWND editContro HRESULT hResult = IUnknown_QueryService(param18, SID_SShellBrowser, IID_PPV_ARG(IBrowserService, &browserService)); if (SUCCEEDED(hResult)) { - if (SUCCEEDED(hResult)) - hResult = AtlAdvise(browserService, static_cast(this), DIID_DWebBrowserEvents, &fAdviseCookie); + hResult = AtlAdvise(browserService, static_cast(this), DIID_DWebBrowserEvents, &fAdviseCookie); } return hResult;