[COMPBATT] Annotate all functions with SAL2

This commit is contained in:
George Bișoc 2024-12-14 21:36:49 +01:00
parent f9ea9220d8
commit 8b5423aa60
No known key found for this signature in database
GPG key ID: 688C4FBE25D7DEF6
3 changed files with 96 additions and 70 deletions

View file

@ -20,8 +20,9 @@ ULONG CompBattDebug;
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattOpenClose(IN PDEVICE_OBJECT DeviceObject, CompBattOpenClose(
IN PIRP Irp) _In_ PDEVICE_OBJECT DeviceObject,
_In_ PIRP Irp)
{ {
PAGED_CODE(); PAGED_CODE();
if (CompBattDebug & 0x100) DbgPrint("CompBatt: ENTERING OpenClose\n"); if (CompBattDebug & 0x100) DbgPrint("CompBatt: ENTERING OpenClose\n");
@ -38,8 +39,9 @@ CompBattOpenClose(IN PDEVICE_OBJECT DeviceObject,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattSystemControl(IN PDEVICE_OBJECT DeviceObject, CompBattSystemControl(
IN PIRP Irp) _In_ PDEVICE_OBJECT DeviceObject,
_In_ PIRP Irp)
{ {
PCOMPBATT_DEVICE_EXTENSION DeviceExtension = DeviceObject->DeviceExtension; PCOMPBATT_DEVICE_EXTENSION DeviceExtension = DeviceObject->DeviceExtension;
NTSTATUS Status; NTSTATUS Status;
@ -67,17 +69,10 @@ CompBattSystemControl(IN PDEVICE_OBJECT DeviceObject,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattMonitorIrpComplete(IN PDEVICE_OBJECT DeviceObject, CompBattMonitorIrpComplete(
IN PIRP Irp, _In_ PDEVICE_OBJECT DeviceObject,
IN PKEVENT Event) _In_ PIRP Irp,
{ _In_ PVOID Context)
UNIMPLEMENTED;
return STATUS_NOT_IMPLEMENTED;
}
NTSTATUS
NTAPI
CompBattMonitorIrpCompleteWorker(IN PCOMPBATT_BATTERY_DATA BatteryData)
{ {
UNIMPLEMENTED; UNIMPLEMENTED;
return STATUS_NOT_IMPLEMENTED; return STATUS_NOT_IMPLEMENTED;
@ -85,7 +80,17 @@ CompBattMonitorIrpCompleteWorker(IN PCOMPBATT_BATTERY_DATA BatteryData)
VOID VOID
NTAPI NTAPI
CompBattRecalculateTag(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) CompBattMonitorIrpCompleteWorker(
_In_ PCOMPBATT_BATTERY_DATA BatteryData)
{
UNIMPLEMENTED;
return STATUS_NOT_IMPLEMENTED;
}
VOID
NTAPI
CompBattRecalculateTag(
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
PCOMPBATT_BATTERY_DATA BatteryData; PCOMPBATT_BATTERY_DATA BatteryData;
ULONG Tag; ULONG Tag;
@ -122,8 +127,9 @@ CompBattRecalculateTag(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattIoctl(IN PDEVICE_OBJECT DeviceObject, CompBattIoctl(
IN PIRP Irp) _In_ PDEVICE_OBJECT DeviceObject,
_In_ PIRP Irp)
{ {
PCOMPBATT_DEVICE_EXTENSION DeviceExtension = DeviceObject->DeviceExtension; PCOMPBATT_DEVICE_EXTENSION DeviceExtension = DeviceObject->DeviceExtension;
NTSTATUS Status; NTSTATUS Status;
@ -146,8 +152,9 @@ CompBattIoctl(IN PDEVICE_OBJECT DeviceObject,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattQueryTag(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension, CompBattQueryTag(
OUT PULONG Tag) _In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension,
_Out_ PULONG Tag)
{ {
NTSTATUS Status; NTSTATUS Status;
PAGED_CODE(); PAGED_CODE();
@ -181,7 +188,8 @@ CompBattQueryTag(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattDisableStatusNotify(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) CompBattDisableStatusNotify(
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
PCOMPBATT_BATTERY_DATA BatteryData; PCOMPBATT_BATTERY_DATA BatteryData;
PLIST_ENTRY ListHead, NextEntry; PLIST_ENTRY ListHead, NextEntry;
@ -208,9 +216,10 @@ CompBattDisableStatusNotify(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattSetStatusNotify(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension, CompBattSetStatusNotify(
IN ULONG BatteryTag, _In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension,
IN PBATTERY_NOTIFY BatteryNotify) _In_ ULONG BatteryTag,
_In_ PBATTERY_NOTIFY BatteryNotify)
{ {
UNIMPLEMENTED; UNIMPLEMENTED;
return STATUS_NOT_IMPLEMENTED; return STATUS_NOT_IMPLEMENTED;
@ -218,9 +227,10 @@ CompBattSetStatusNotify(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattQueryStatus(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension, CompBattQueryStatus(
IN ULONG Tag, _In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension,
IN PBATTERY_STATUS BatteryStatus) _In_ ULONG Tag,
_Out_ PBATTERY_STATUS BatteryStatus)
{ {
UNIMPLEMENTED; UNIMPLEMENTED;
return STATUS_NOT_IMPLEMENTED; return STATUS_NOT_IMPLEMENTED;
@ -228,8 +238,9 @@ CompBattQueryStatus(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattGetBatteryInformation(OUT PBATTERY_INFORMATION BatteryInfo, CompBattGetBatteryInformation(
IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) _Out_ PBATTERY_INFORMATION BatteryInfo,
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
NTSTATUS Status = STATUS_SUCCESS; NTSTATUS Status = STATUS_SUCCESS;
BATTERY_QUERY_INFORMATION InputBuffer; BATTERY_QUERY_INFORMATION InputBuffer;
@ -384,8 +395,9 @@ CompBattGetBatteryInformation(OUT PBATTERY_INFORMATION BatteryInfo,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattGetBatteryGranularity(OUT PBATTERY_REPORTING_SCALE ReportingScale, CompBattGetBatteryGranularity(
IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) _Out_ PBATTERY_REPORTING_SCALE ReportingScale,
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
NTSTATUS Status = STATUS_SUCCESS; NTSTATUS Status = STATUS_SUCCESS;
BATTERY_QUERY_INFORMATION InputBuffer; BATTERY_QUERY_INFORMATION InputBuffer;
@ -470,8 +482,9 @@ CompBattGetBatteryGranularity(OUT PBATTERY_REPORTING_SCALE ReportingScale,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattGetEstimatedTime(OUT PULONG Time, CompBattGetEstimatedTime(
IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) _Out_ PULONG Time,
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
UNIMPLEMENTED; UNIMPLEMENTED;
return STATUS_NOT_IMPLEMENTED; return STATUS_NOT_IMPLEMENTED;
@ -479,13 +492,14 @@ CompBattGetEstimatedTime(OUT PULONG Time,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattQueryInformation(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension, CompBattQueryInformation(
IN ULONG Tag, _In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension,
IN BATTERY_QUERY_INFORMATION_LEVEL InfoLevel, _In_ ULONG Tag,
IN OPTIONAL LONG AtRate, _In_ BATTERY_QUERY_INFORMATION_LEVEL InfoLevel,
IN PVOID Buffer, _In_opt_ LONG AtRate,
IN ULONG BufferLength, _In_ PVOID Buffer,
OUT PULONG ReturnedLength) _In_ ULONG BufferLength,
_Out_ PULONG ReturnedLength)
{ {
BATTERY_INFORMATION BatteryInfo; BATTERY_INFORMATION BatteryInfo;
BATTERY_REPORTING_SCALE BatteryGranularity[4]; BATTERY_REPORTING_SCALE BatteryGranularity[4];
@ -593,8 +607,9 @@ CompBattQueryInformation(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension,
NTSTATUS NTSTATUS
NTAPI NTAPI
DriverEntry(IN PDRIVER_OBJECT DriverObject, DriverEntry(
IN PUNICODE_STRING RegistryPath) _In_ PDRIVER_OBJECT DriverObject,
_In_ PUNICODE_STRING RegistryPath)
{ {
/* Register add device routine */ /* Register add device routine */
DriverObject->DriverExtension->AddDevice = CompBattAddDevice; DriverObject->DriverExtension->AddDevice = CompBattAddDevice;

View file

@ -14,13 +14,14 @@
NTSTATUS NTSTATUS
NTAPI NTAPI
BatteryIoctl(IN ULONG IoControlCode, BatteryIoctl(
IN PDEVICE_OBJECT DeviceObject, _In_ ULONG IoControlCode,
IN PVOID InputBuffer, _In_ PDEVICE_OBJECT DeviceObject,
IN ULONG InputBufferLength, _In_ PVOID InputBuffer,
IN PVOID OutputBuffer, _In_ ULONG InputBufferLength,
IN ULONG OutputBufferLength, _Out_ PVOID OutputBuffer,
IN BOOLEAN InternalDeviceIoControl) _Inout_ ULONG OutputBufferLength,
_In_ BOOLEAN InternalDeviceIoControl)
{ {
IO_STATUS_BLOCK IoStatusBlock; IO_STATUS_BLOCK IoStatusBlock;
KEVENT Event; KEVENT Event;
@ -71,10 +72,11 @@ BatteryIoctl(IN ULONG IoControlCode,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattGetDeviceObjectPointer(IN PUNICODE_STRING DeviceName, CompBattGetDeviceObjectPointer(
IN ACCESS_MASK DesiredAccess, _In_ PUNICODE_STRING DeviceName,
OUT PFILE_OBJECT *FileObject, _In_ ACCESS_MASK DesiredAccess,
OUT PDEVICE_OBJECT *DeviceObject) _Out_ PFILE_OBJECT *FileObject,
_Out_ PDEVICE_OBJECT *DeviceObject)
{ {
NTSTATUS Status; NTSTATUS Status;
OBJECT_ATTRIBUTES ObjectAttributes; OBJECT_ATTRIBUTES ObjectAttributes;

View file

@ -16,8 +16,9 @@
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattPowerDispatch(IN PDEVICE_OBJECT DeviceObject, CompBattPowerDispatch(
IN PIRP Irp) _In_ PDEVICE_OBJECT DeviceObject,
_In_ PIRP Irp)
{ {
PCOMPBATT_DEVICE_EXTENSION DeviceExtension = DeviceObject->DeviceExtension; PCOMPBATT_DEVICE_EXTENSION DeviceExtension = DeviceObject->DeviceExtension;
if (CompBattDebug & 1) DbgPrint("CompBatt: PowerDispatch received power IRP.\n"); if (CompBattDebug & 1) DbgPrint("CompBatt: PowerDispatch received power IRP.\n");
@ -32,8 +33,9 @@ CompBattPowerDispatch(IN PDEVICE_OBJECT DeviceObject,
PCOMPBATT_BATTERY_DATA PCOMPBATT_BATTERY_DATA
NTAPI NTAPI
RemoveBatteryFromList(IN PCUNICODE_STRING BatteryName, RemoveBatteryFromList(
IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) _In_ PCUNICODE_STRING BatteryName,
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
PLIST_ENTRY ListHead, NextEntry; PLIST_ENTRY ListHead, NextEntry;
PCOMPBATT_BATTERY_DATA BatteryData; PCOMPBATT_BATTERY_DATA BatteryData;
@ -74,8 +76,9 @@ RemoveBatteryFromList(IN PCUNICODE_STRING BatteryName,
BOOLEAN BOOLEAN
NTAPI NTAPI
IsBatteryAlreadyOnList(IN PCUNICODE_STRING BatteryName, IsBatteryAlreadyOnList(
IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) _In_ PCUNICODE_STRING BatteryName,
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
PLIST_ENTRY ListHead, NextEntry; PLIST_ENTRY ListHead, NextEntry;
PCOMPBATT_BATTERY_DATA BatteryData; PCOMPBATT_BATTERY_DATA BatteryData;
@ -110,8 +113,9 @@ IsBatteryAlreadyOnList(IN PCUNICODE_STRING BatteryName,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattAddNewBattery(IN PUNICODE_STRING BatteryName, CompBattAddNewBattery(
IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) _In_ PUNICODE_STRING BatteryName,
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
NTSTATUS Status = STATUS_SUCCESS; NTSTATUS Status = STATUS_SUCCESS;
PCOMPBATT_BATTERY_DATA BatteryData; PCOMPBATT_BATTERY_DATA BatteryData;
@ -220,8 +224,9 @@ CompBattAddNewBattery(IN PUNICODE_STRING BatteryName,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattRemoveBattery(IN PCUNICODE_STRING BatteryName, CompBattRemoveBattery(
IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) _In_ PCUNICODE_STRING BatteryName,
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
PCOMPBATT_BATTERY_DATA BatteryData; PCOMPBATT_BATTERY_DATA BatteryData;
if (CompBattDebug & 1) DbgPrint("CompBatt: RemoveBattery\n"); if (CompBattDebug & 1) DbgPrint("CompBatt: RemoveBattery\n");
@ -245,7 +250,8 @@ CompBattRemoveBattery(IN PCUNICODE_STRING BatteryName,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattGetBatteries(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) CompBattGetBatteries(
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
PWCHAR p; PWCHAR p;
NTSTATUS Status; NTSTATUS Status;
@ -286,8 +292,9 @@ CompBattGetBatteries(IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattPnpEventHandler(IN PDEVICE_INTERFACE_CHANGE_NOTIFICATION Notification, CompBattPnpEventHandler(
IN PCOMPBATT_DEVICE_EXTENSION DeviceExtension) _In_ PDEVICE_INTERFACE_CHANGE_NOTIFICATION Notification,
_In_ PCOMPBATT_DEVICE_EXTENSION DeviceExtension)
{ {
if (CompBattDebug & 1) DbgPrint("CompBatt: ENTERING PnpEventHandler\n"); if (CompBattDebug & 1) DbgPrint("CompBatt: ENTERING PnpEventHandler\n");
if (CompBattDebug & 2) DbgPrint("CompBatt: Received device interface change notification\n"); if (CompBattDebug & 2) DbgPrint("CompBatt: Received device interface change notification\n");
@ -319,8 +326,9 @@ CompBattPnpEventHandler(IN PDEVICE_INTERFACE_CHANGE_NOTIFICATION Notification,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattAddDevice(IN PDRIVER_OBJECT DriverObject, CompBattAddDevice(
IN PDEVICE_OBJECT PdoDeviceObject) _In_ PDRIVER_OBJECT DriverObject,
_In_ PDEVICE_OBJECT PdoDeviceObject)
{ {
NTSTATUS Status; NTSTATUS Status;
UNICODE_STRING DeviceName; UNICODE_STRING DeviceName;
@ -402,8 +410,9 @@ CompBattAddDevice(IN PDRIVER_OBJECT DriverObject,
NTSTATUS NTSTATUS
NTAPI NTAPI
CompBattPnpDispatch(IN PDEVICE_OBJECT DeviceObject, CompBattPnpDispatch(
IN PIRP Irp) _In_ PDEVICE_OBJECT DeviceObject,
_In_ PIRP Irp)
{ {
PIO_STACK_LOCATION IoStackLocation = IoGetCurrentIrpStackLocation(Irp); PIO_STACK_LOCATION IoStackLocation = IoGetCurrentIrpStackLocation(Irp);
NTSTATUS Status; NTSTATUS Status;