Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-28 08:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[GDI32] Fix memory leak in case of public DC. CORE-18498

Browse source
This commit is contained in:
Thomas Faber 2023-01-16 14:24:07 -05:00
parent f34e425e1a
commit 8b19b6ec5a
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
win32ss/gdi/gdi32/objects/bitmap.c
View file

@ -756,8 +756,10 @@ SetDIBitsToDevice(
if (!GdiGetHandleUserData(hdc, GDI_OBJECT_TYPE_DC, (PVOID) & pDc_Attr)) if (!GdiGetHandleUserData(hdc, GDI_OBJECT_TYPE_DC, (PVOID) & pDc_Attr))
{ {
DPRINT1("SetDIBitsToDevice called on invalid DC %p (not owned?)\n", hdc);
SetLastError(ERROR_INVALID_PARAMETER); SetLastError(ERROR_INVALID_PARAMETER);
return 0; LinesCopied = 0;
goto Exit;
} }
/* /*
if ( !pDc_Attr || // DC is Public if ( !pDc_Attr || // DC is Public
@ -867,8 +869,10 @@ StretchDIBits(
if (!GdiGetHandleUserData(hdc, GDI_OBJECT_TYPE_DC, (PVOID) & pDc_Attr)) if (!GdiGetHandleUserData(hdc, GDI_OBJECT_TYPE_DC, (PVOID) & pDc_Attr))
{ {
DPRINT1("StretchDIBits called on invalid DC %p (not owned?)\n", hdc);
SetLastError(ERROR_INVALID_PARAMETER); SetLastError(ERROR_INVALID_PARAMETER);
return 0; LinesCopied = 0;
goto Exit;
} }
/* /*
if ( !pDc_Attr || if ( !pDc_Attr ||
@ -894,6 +898,7 @@ StretchDIBits(
cjBmpScanSize, cjBmpScanSize,
NULL ); NULL );
} }
Exit:
if (pvSafeBits) if (pvSafeBits)
RtlFreeHeap(RtlGetProcessHeap(), 0, pvSafeBits); RtlFreeHeap(RtlGetProcessHeap(), 0, pvSafeBits);
if (lpBitsInfo != pConvertedInfo) if (lpBitsInfo != pConvertedInfo)