Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-09-30 22:47:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a buffer overflow. Thanks to Christoph for spotting this.

Browse source 
svn path=/trunk/; revision=20665
This commit is contained in:
Ged Murphy 2006-01-07 19:14:03 +00:00
parent 6f8f61fade
commit 8889751923
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
reactos/subsys/system/servman/query.c
View file

@ -39,7 +39,7 @@ RefreshServiceList(VOID)
{
HICON hiconItem; /* icon for list-view items */
HIMAGELIST hSmall; /* image list for other views */
TCHAR buf[40];
TCHAR buf[256];
/* Create the icon image lists */
hSmall = ImageList_Create(GetSystemMetrics(SM_CXSMICON),
@ -85,14 +85,8 @@ RefreshServiceList(VOID)
ZeroMemory(&item, sizeof(LV_ITEM));
item.mask = LVIF_TEXT;
item.iImage = 0;
item.pszText = pServiceStatus[Index].lpDisplayName;
/*_tcsncpy(item.pszText,
pServiceStatus[Index].lpDisplayName,
sizeof(pServiceStatus[Index].lpDisplayName));*/
item.iItem = ListView_GetItemCount(hListView);
item.lParam = 0;
item.iItem = ListView_InsertItem(hListView, &item);
@ -137,7 +131,12 @@ RefreshServiceList(VOID)
HeapFree(GetProcessHeap(), 0, Description);
}
else
{
item.pszText = '\0';
item.iSubItem = 1;
SendMessage(hListView, LVM_SETITEMTEXT, item.iItem, (LPARAM) &item);
}
/* set the status */