From 8632758e521699049a7767dfcb8ea38d074e5bfd Mon Sep 17 00:00:00 2001
From: Giannis Adamopoulos <gadamopoulos@reactos.org>
Date: Thu, 10 Nov 2016 09:34:14 +0000
Subject: [PATCH] [SHELL32] - CStartMenu: Add missing checks for failure and
 make some checks noisy. CORE-12300

svn path=/trunk/; revision=73189
---
 .../win32/shell32/shellmenu/CStartMenu.cpp    | 23 +++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/reactos/dll/win32/shell32/shellmenu/CStartMenu.cpp b/reactos/dll/win32/shell32/shellmenu/CStartMenu.cpp
index 6959055be9d..f01957dd73f 100644
--- a/reactos/dll/win32/shell32/shellmenu/CStartMenu.cpp
+++ b/reactos/dll/win32/shell32/shellmenu/CStartMenu.cpp
@@ -167,6 +167,8 @@ private:
             return hr;
 
         hr = pShellMenu->Initialize(this, 0, ANCESTORDEFAULT, SMINIT_VERTICAL);
+        if (FAILED_UNEXPECTEDLY(hr))
+            return hr;
 
         switch (psmd->uId)
         {
@@ -188,11 +190,22 @@ private:
                 LPITEMIDLIST pidlStartMenu;
                 IShellFolder *psfDestop;
                 hr = SHGetFolderLocation(NULL, csidl, 0, 0, &pidlStartMenu);
+                if (FAILED_UNEXPECTEDLY(hr))
+                    return hr;
+
                 hr = SHGetDesktopFolder(&psfDestop);
+                if (FAILED_UNEXPECTEDLY(hr))
+                    return hr;
+
                 hr = psfDestop->BindToObject(pidlStartMenu, NULL, IID_PPV_ARG(IShellFolder, &psfStartMenu));
+                if (FAILED_UNEXPECTEDLY(hr))
+                    return hr;
             }
 
             hr = pShellMenu->SetShellFolder(psfStartMenu, NULL, NULL, 0);
+            if (FAILED_UNEXPECTEDLY(hr))
+                return hr;
+
         }
         else
         {
@@ -202,6 +215,8 @@ private:
             if (GetMenuItemInfoW(psmd->hmenu, psmd->uId, FALSE, &mii))
             {
                 hr = pShellMenu->SetMenu(mii.hSubMenu, NULL, SMSET_BOTTOM);
+                if (FAILED_UNEXPECTEDLY(hr))
+                    return hr;
             }
         }
         return pShellMenu->QueryInterface(iid, pv);
@@ -475,7 +490,7 @@ CStartMenu_Constructor(REFIID riid, void **ppv)
     /* psf is a merged folder, so now we want to get the pidl of the programs item from the merged folder */
     {
         hr = SHGetSpecialFolderLocation(NULL, CSIDL_PROGRAMS, &pidlProgramsAbsolute);
-        if (FAILED(hr))
+        if (FAILED_UNEXPECTEDLY(hr))
         {
             WARN("USER Programs folder not found.");
             hr = SHGetSpecialFolderLocation(NULL, CSIDL_COMMON_PROGRAMS, &pidlProgramsAbsolute);
@@ -489,11 +504,11 @@ CStartMenu_Constructor(REFIID riid, void **ppv)
         TCHAR szDisplayName[MAX_PATH];
 
         hr = SHBindToParent(pidlProgramsAbsolute, IID_PPV_ARG(IShellFolder, &psfParent), &pcidlPrograms);
-        if (FAILED(hr))
+        if (FAILED_UNEXPECTEDLY(hr))
             return hr;
 
         hr = psfParent->GetDisplayNameOf(pcidlPrograms, SHGDN_FORPARSING | SHGDN_INFOLDER, &str);
-        if (FAILED(hr))
+        if (FAILED_UNEXPECTEDLY(hr))
             return hr;
 
         StrRetToBuf(&str, pcidlPrograms, szDisplayName, _countof(szDisplayName));
@@ -501,7 +516,7 @@ CStartMenu_Constructor(REFIID riid, void **ppv)
 
         /* We got the display name from the fs folder and we parse it with the merged folder here */
         hr = psf->ParseDisplayName(NULL, NULL, szDisplayName, NULL, &pidlPrograms, NULL);
-        if (FAILED(hr))
+        if (FAILED_UNEXPECTEDLY(hr))
             return hr;
     }