Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-28 19:32:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS:KE/x64] Improve freeze code

Browse source 
- Set ACTIVE flag on freeze owner like on Windows
- Add a nice state graph
- Change license to MIT
This commit is contained in:
Timo Kreuzer 2024-12-13 12:59:28 +02:00
parent a17d32a373
commit 85f42a25d5
1 changed files with 34 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
ntoskrnl/ke/amd64/freeze.c
View file

@ -1,8 +1,30 @@
/* /*
* PROJECT: ReactOS Kernel * PROJECT: ReactOS Kernel
* LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) * LICENSE: MIT (https://spdx.org/licenses/MIT)
* PURPOSE: Processor freeze support for x64 * PURPOSE: Processor freeze support for x64
* COPYRIGHT: Copyright 2023 Timo Kreuzer <timo.kreuzer@reactos.org> * COPYRIGHT: Copyright 2023-2024 Timo Kreuzer <timo.kreuzer@reactos.org>
*/
/*
IpiFrozen state graph (based on Windows behavior):
+-----------------+ Freeze request +-----------------+
| RUNNING |------------------------>| TARGET_FREEZE |
+-----------------+<--------- +-----------------+
|^ | Resume |
Freeze || Thaw +-----------+ Thaw request | Freeze IPI
v| | THAW |<-----------\ v
+-----------------+ +-----------+ +-----------------+
| OWNER + ACTIVE | ^ | FROZEN |
+-----------------+ | +-----------------+
^ | ^
| Kd proc switch | | Kd proc switch
v | v
+-----------------+ | +-----------------+
| OWNER |---------+ | FROZEN + ACTIVE |
+-----------------+ Thaw request +-----------------+
*/ */
/* INCLUDES *******************************************************************/ /* INCLUDES *******************************************************************/
@ -98,8 +120,8 @@ KxFreezeExecution(
} }
} }
/* We are the owner now */ /* We are the owner now and active */
CurrentPrcb->IpiFrozen = IPI_FROZEN_STATE_OWNER; CurrentPrcb->IpiFrozen = IPI_FROZEN_STATE_OWNER | IPI_FROZEN_FLAG_ACTIVE;
/* Loop all processors */ /* Loop all processors */
for (ULONG i = 0; i < KeNumberProcessors; i++) for (ULONG i = 0; i < KeNumberProcessors; i++)
@ -107,7 +129,7 @@ KxFreezeExecution(
PKPRCB TargetPrcb = KiProcessorBlock[i]; PKPRCB TargetPrcb = KiProcessorBlock[i];
if (TargetPrcb != CurrentPrcb) if (TargetPrcb != CurrentPrcb)
{ {
/* Nobody else is allowed to change IpiFrozen, except the freeze owner */ /* Only the active processor is allowed to change IpiFrozen */
ASSERT(TargetPrcb->IpiFrozen == IPI_FROZEN_STATE_RUNNING); ASSERT(TargetPrcb->IpiFrozen == IPI_FROZEN_STATE_RUNNING);
/* Request target to freeze */ /* Request target to freeze */
@ -142,6 +164,7 @@ KxThawExecution(
VOID) VOID)
{ {
PKPRCB CurrentPrcb = KeGetCurrentPrcb(); PKPRCB CurrentPrcb = KeGetCurrentPrcb();
ASSERT(CurrentPrcb->IpiFrozen & IPI_FROZEN_FLAG_ACTIVE);
/* Loop all processors */ /* Loop all processors */
for (ULONG i = 0; i < KeNumberProcessors; i++) for (ULONG i = 0; i < KeNumberProcessors; i++)
@ -190,6 +213,10 @@ KxSwitchKdProcessor(
/* Make sure that the processor index is valid */ /* Make sure that the processor index is valid */
ASSERT(ProcessorIndex < KeNumberProcessors); ASSERT(ProcessorIndex < KeNumberProcessors);
/* We are no longer active */
ASSERT(CurrentPrcb->IpiFrozen & IPI_FROZEN_FLAG_ACTIVE);
CurrentPrcb->IpiFrozen &= ~IPI_FROZEN_FLAG_ACTIVE;
/* Inform the target processor that it's his turn now */ /* Inform the target processor that it's his turn now */
TargetPrcb = KiProcessorBlock[ProcessorIndex]; TargetPrcb = KiProcessorBlock[ProcessorIndex];
TargetPrcb->IpiFrozen |= IPI_FROZEN_FLAG_ACTIVE; TargetPrcb->IpiFrozen |= IPI_FROZEN_FLAG_ACTIVE;
@ -212,12 +239,12 @@ KxSwitchKdProcessor(
{ {
/* Another CPU has completed, we can leave the debugger now */ /* Another CPU has completed, we can leave the debugger now */
KdpDprintf("[%u] KxSwitchKdProcessor: ContinueSuccess\n", KeGetCurrentProcessorNumber()); KdpDprintf("[%u] KxSwitchKdProcessor: ContinueSuccess\n", KeGetCurrentProcessorNumber());
CurrentPrcb->IpiFrozen = IPI_FROZEN_STATE_OWNER; CurrentPrcb->IpiFrozen = IPI_FROZEN_STATE_OWNER | IPI_FROZEN_FLAG_ACTIVE;
return ContinueSuccess; return ContinueSuccess;
} }
/* We have been reselected, return to Kd to continue in the debugger */ /* We have been reselected, return to Kd to continue in the debugger */
CurrentPrcb->IpiFrozen = IPI_FROZEN_STATE_OWNER; ASSERT(CurrentPrcb->IpiFrozen == (IPI_FROZEN_STATE_OWNER | IPI_FROZEN_FLAG_ACTIVE));
return ContinueProcessorReselected; return ContinueProcessorReselected;
} }