Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-27 09:00:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

[GDI32] Fix MSVC warning in SetDIBitsToDevice and simplify code. (#7919)

Browse source 
This is a very small revert of PR #5227 to simplify the code and eliminate an MSVC warning.
It was pointed out by Timo Kreuzer as probably not doing what I intended and he was correct.
I added this code in PR #5227 to try and correct some return values from SetDIBitsToDevice.
After testing with this new PR, there was no difference in the regression tests for either
1) gdi32:bitmap or 2) gdi32:SetDIBitsToDevice after deleting the code here and the MSVC warning was fixed.
This commit is contained in:
Doug Lyons 2025-04-24 21:04:36 -05:00 committed by GitHub
parent efbdd483b3
commit 85afe48c3e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
win32ss/gdi/gdi32/objects/bitmap.c
View file

@ -1019,8 +1019,7 @@ SetDIBitsToDevice(
if (pConvertedInfo->bmiHeader.biHeight < 0)
{
if (pConvertedInfo->bmiHeader.biHeight < -MaxSourceHeight ||
(YDest >= 0 && src_y < -ScanLines))
if (pConvertedInfo->bmiHeader.biHeight < -MaxSourceHeight || YDest >= 0)
{
LinesCopied = ScanLines + src_y;
}