From 830e15b622515b3f70e7cafc07d15173fa3df1b1 Mon Sep 17 00:00:00 2001 From: Eric Kohl Date: Mon, 21 Jun 2021 21:33:24 +0200 Subject: [PATCH] [UMPNPMGR] Add missing parameter checks to PNP_GetDeviceStatus --- base/services/umpnpmgr/rpcserver.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/base/services/umpnpmgr/rpcserver.c b/base/services/umpnpmgr/rpcserver.c index d84e0cab4ff..bb63bce02bd 100644 --- a/base/services/umpnpmgr/rpcserver.c +++ b/base/services/umpnpmgr/rpcserver.c @@ -22,7 +22,7 @@ * FILE: base/services/umpnpmgr/rpcserver.c * PURPOSE: RPC server * PROGRAMMER: Eric Kohl (eric.kohl@reactos.org) - * Hervé Poussineau (hpoussin@reactos.org) + * HervĂ© Poussineau (hpoussin@reactos.org) * Colin Finck (colin@reactos.org) */ @@ -3199,6 +3199,12 @@ PNP_GetDeviceStatus( DPRINT("PNP_GetDeviceStatus(%p %S %p %p 0x%08lx)\n", hBinding, pDeviceID, pulStatus, pulProblem, ulFlags); + if (ulFlags != 0) + return CR_INVALID_FLAG; + + if ((pulStatus == NULL) || (pulProblem == NULL)) + return CR_INVALID_POINTER; + if (!IsValidDeviceInstanceID(pDeviceID)) return CR_INVALID_DEVINST;