Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-08-14 15:16:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allocate buffer for system directory on heap instead of stack

Browse source 
svn path=/trunk/; revision=22273
This commit is contained in:
Hervé Poussineau 2006-06-07 17:30:06 +00:00
parent 9d4e17c705
commit 7e07a60d3a
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
reactos/dll/win32/setupapi/devinst.c
View file

@ -409,9 +409,6 @@ CheckSectionValid(
DWORD i; DWORD i;
BOOL ret = FALSE; BOOL ret = FALSE;
TRACE("%s %p 0x%x 0x%x\n",
debugstr_w(SectionName), PlatformInfo, ProductType, SuiteMask);
static const WCHAR ExtensionPlatformNone[] = {'.',0}; static const WCHAR ExtensionPlatformNone[] = {'.',0};
static const WCHAR ExtensionPlatformNT[] = {'.','N','T',0}; static const WCHAR ExtensionPlatformNT[] = {'.','N','T',0};
static const WCHAR ExtensionPlatformWindows[] = {'.','W','i','n',0}; static const WCHAR ExtensionPlatformWindows[] = {'.','W','i','n',0};
@ -424,6 +421,9 @@ CheckSectionValid(
static const WCHAR ExtensionArchitectureppc[] = {'p','p','c',0}; static const WCHAR ExtensionArchitectureppc[] = {'p','p','c',0};
static const WCHAR ExtensionArchitecturex86[] = {'x','8','6',0}; static const WCHAR ExtensionArchitecturex86[] = {'x','8','6',0};
TRACE("%s %p 0x%x 0x%x\n",
debugstr_w(SectionName), PlatformInfo, ProductType, SuiteMask);
*ScorePlatform = *ScoreMajorVersion = *ScoreMinorVersion = *ScoreProductType = *ScoreSuiteMask = 0; *ScorePlatform = *ScoreMajorVersion = *ScoreMinorVersion = *ScoreProductType = *ScoreSuiteMask = 0;
Section = DuplicateString(SectionName); Section = DuplicateString(SectionName);
@ -3198,12 +3198,20 @@ InfIsFromOEMLocation(
} }
else else
{ {
WCHAR Windir[MAX_PATH + 1 + strlenW(InfDirectory)]; LPWSTR Windir;
UINT ret; UINT ret;
Windir = MyMalloc((MAX_PATH + 1 + strlenW(InfDirectory)) * sizeof(WCHAR));
if (!Windir)
{
SetLastError(ERROR_NOT_ENOUGH_MEMORY);
return FALSE;
}
ret = GetSystemWindowsDirectoryW(Windir, MAX_PATH); ret = GetSystemWindowsDirectoryW(Windir, MAX_PATH);
if (ret == 0 || ret > MAX_PATH) if (ret == 0 || ret > MAX_PATH)
{ {
MyFree(Windir);
SetLastError(ERROR_GEN_FAILURE); SetLastError(ERROR_GEN_FAILURE);
return FALSE; return FALSE;
} }
@ -3221,6 +3229,7 @@ InfIsFromOEMLocation(
/* The file is in another place */ /* The file is in another place */
*IsOEMLocation = TRUE; *IsOEMLocation = TRUE;
} }
MyFree(Windir);
} }
return TRUE; return TRUE;
} }