From 7b57d6a08d59527ca48c6c53b5b06124868649ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= <hpoussin@reactos.org>
Date: Fri, 19 Oct 2007 13:20:27 +0000
Subject: [PATCH] Const-ify Define class

svn path=/trunk/; revision=29680
---
 reactos/tools/rbuild/define.cpp  | 19 +++++++++----------
 reactos/tools/rbuild/project.dtd |  2 --
 reactos/tools/rbuild/rbuild.h    |  4 ++--
 3 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/reactos/tools/rbuild/define.cpp b/reactos/tools/rbuild/define.cpp
index 9e666bd45d3..03ec41187c3 100644
--- a/reactos/tools/rbuild/define.cpp
+++ b/reactos/tools/rbuild/define.cpp
@@ -33,7 +33,7 @@ Define::Define ( const Project& project,
 }
 
 Define::Define ( const Project& project,
-	             const Module* module,
+                 const Module* module,
                  const XMLElement& defineNode )
 	: project(project),
 	  module(module),
@@ -43,16 +43,16 @@ Define::Define ( const Project& project,
 }
 
 Define::Define ( const Project& project,
-	             const Module* module,
-	             const std::string name_,
-	             const std::string backend_)
+                 const Module* module,
+                 const std::string& name_,
+                 const std::string& backend_)
 	: project(project),
 	  module(module),
 	  node(NULL)
 {
 	name = name_;
 	value = "";
-    backend = backend_;
+	backend = backend_;
 }
 
 Define::~Define ()
@@ -63,13 +63,12 @@ void
 Define::Initialize()
 {
 	const XMLAttribute* att = node->GetAttribute ( "name", true );
-	const XMLAttribute* empty = node->GetAttribute ( "empty", false );
-    const XMLAttribute* bck = node->GetAttribute ( "backend", false );
+	const XMLAttribute* bck = node->GetAttribute ( "backend", false );
 	assert(att);
 	name = att->value;
-    value = node->value;
-    if ( bck ) backend = bck->value;
-	if( empty ) value = " ";
+	value = node->value;
+	if ( bck )
+		backend = bck->value;
 }
 
 void
diff --git a/reactos/tools/rbuild/project.dtd b/reactos/tools/rbuild/project.dtd
index 9905a606610..fb757c617b2 100644
--- a/reactos/tools/rbuild/project.dtd
+++ b/reactos/tools/rbuild/project.dtd
@@ -37,8 +37,6 @@
 <!ELEMENT define (#PCDATA)>
 <!ATTLIST define
 	name  %CIdentifier; #REQUIRED
-	value %Text;        #IMPLIED
-	empty (true) #IMPLIED
 >
 
 <!ELEMENT directory (compilationunit*|directory*|group*|cdfile|file*|if*|ifnot*|module+|pch*|xi:include*)+>
diff --git a/reactos/tools/rbuild/rbuild.h b/reactos/tools/rbuild/rbuild.h
index 0026e391dd0..f00745e2228 100644
--- a/reactos/tools/rbuild/rbuild.h
+++ b/reactos/tools/rbuild/rbuild.h
@@ -434,8 +434,8 @@ public:
 	         const XMLElement& defineNode );
 	Define ( const Project& project,
 	         const Module* module,
-	         const std::string name_,
-	         const std::string backend_ = "" );
+	         const std::string& name_,
+	         const std::string& backend_ = "" );
 	~Define();
 	void ProcessXML();
 private: