Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 10:04:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTUSER] co_UserDestroyWindow: Validate window before destroying it (#5054)

Browse source 
Prevent the window from being destroyed twice
fixes BSOD 0x1E CORE-18821
This commit is contained in:
Thamatip Chitpong 2023-04-13 03:20:46 +07:00 committed by GitHub
parent 15c755e5f9
commit 77d4653164
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
win32ss/user/ntuser/window.c
View file

@ -2845,6 +2845,15 @@ BOOLEAN co_UserDestroyWindow(PVOID Object)
ASSERT_REFS_CO(Window); // FIXME: Temp HACK? ASSERT_REFS_CO(Window); // FIXME: Temp HACK?
/* NtUserDestroyWindow does check if the window has already been destroyed
but co_UserDestroyWindow can be called from more paths which means
that it can also be called for a window that has already been destroyed. */
if (!IntIsWindow(UserHMGetHandle(Window)))
{
TRACE("Tried to destroy a window twice\n");
return TRUE;
}
hWnd = Window->head.h; hWnd = Window->head.h;
ti = PsGetCurrentThreadWin32Thread(); ti = PsGetCurrentThreadWin32Thread();