Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-05 23:12:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

- Handle potential null-pointer access. Found by Amine Khaldi.

Browse source 
svn path=/trunk/; revision=43050
This commit is contained in:
Dmitry Chapyshev 2009-09-14 11:13:54 +00:00
parent 398838e6c3
commit 75b7890a52
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
reactos/drivers/usb/nt4compat/usbdriver/ehci.c
View file

@ -1573,6 +1573,7 @@ ehci_internal_submit_bulk(PEHCI_DEV ehci, PURB purb)
PEHCI_QTD_CONTENT ptdc; PEHCI_QTD_CONTENT ptdc;
PEHCI_QH_CONTENT pqhc; PEHCI_QH_CONTENT pqhc;
PEHCI_ELEM_LINKS pelnk; PEHCI_ELEM_LINKS pelnk;
PEHCI_ELEM_LINKS plnk;
if (ehci == NULL || purb == NULL) if (ehci == NULL || purb == NULL)
return STATUS_INVALID_PARAMETER; return STATUS_INVALID_PARAMETER;
@ -1685,7 +1686,17 @@ ehci_internal_submit_bulk(PEHCI_DEV ehci, PURB purb)
RemoveEntryList(&td_list); RemoveEntryList(&td_list);
elem_pool_lock(qh_pool, TRUE); elem_pool_lock(qh_pool, TRUE);
pqh = (PEHCI_QH) ((ULONG) elem_pool_alloc_elem(qh_pool)->phys_part & PHYS_PART_ADDR_MASK);
plnk = elem_pool_alloc_elem(qh_pool);
if (plnk == NULL)
{
// free the qtds
elem_safe_free(pthis, TRUE);
if (qh_pool) elem_pool_unlock(qh_pool, TRUE);
return STATUS_UNSUCCESSFUL;
}
pqh = (PEHCI_QH) ((ULONG) plnk->phys_part & PHYS_PART_ADDR_MASK);
elem_pool_unlock(qh_pool, TRUE); elem_pool_unlock(qh_pool, TRUE);
if (pqh == NULL) if (pqh == NULL)