[EXPLORER_NEW]

- Prefer HEAP_ZERO_MEMORY over a separate ZeroMemory call. Patch by Carlo Bramini.
CORE-6928 #resolve

svn path=/trunk/; revision=58263
This commit is contained in:
Thomas Faber 2013-02-02 10:55:29 +00:00
parent 37f8edd307
commit 7537a1a708
7 changed files with 10 additions and 35 deletions

View file

@ -131,14 +131,11 @@ CreateDropTarget(IN HWND hwndTarget,
HRESULT hr;
This = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
FIELD_OFFSET(IDropTargetImpl,
Formats[nSupportedFormats]));
if (This != NULL)
{
ZeroMemory(This,
sizeof(*This));
This->lpVtbl = &IDropTargetImpl_Vtbl;
This->Ref = 1;
This->hwndTarget = hwndTarget;

View file

@ -773,14 +773,11 @@ IStartMenuSiteImpl_Construct(IN ITrayWindow *Tray)
IStartMenuSiteImpl *This;
This = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*This));
if (This == NULL)
return NULL;
ZeroMemory(This,
sizeof(*This));
This->lpVtbl = &IStartMenuSiteImpl_Vtbl;
This->lpServiceProviderVtbl = &IServiceProviderImpl_Vtbl;
This->lpStartMenuCallbackVtbl = &ITrayPrivImpl_Vtbl;

View file

@ -629,13 +629,11 @@ ITaskBandImpl_Construct(IN OUT ITrayWindow *Tray)
ITaskBandImpl *This;
This = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*This));
if (This == NULL)
return NULL;
ZeroMemory(This,
sizeof(*This));
This->lpVtbl = &ITaskBandImpl_Vtbl;
This->lpDeskBandVtbl = &IDeskBandImpl_Vtbl;
This->lpObjectWithSiteVtbl = &IObjectWithSiteImpl_Vtbl;

View file

@ -709,13 +709,10 @@ TaskSwitchWnd_AddToTaskGroup(IN OUT PTASK_SWITCH_WND This,
/* Allocate a new task group */
TaskGroup = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*TaskGroup));
if (TaskGroup != NULL)
{
ZeroMemory(TaskGroup,
sizeof(*TaskGroup));
TaskGroup->dwTaskCount = 1;
TaskGroup->dwProcessId = dwProcessId;
TaskGroup->Index = -1;
@ -2065,13 +2062,11 @@ ForwardContextMenuMsg:
{
LPCREATESTRUCT CreateStruct = (LPCREATESTRUCT)lParam;
This = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*This));
if (This == NULL)
return FALSE;
ZeroMemory(This,
sizeof(*This));
This->hWnd = hwnd;
This->hWndNotify = CreateStruct->hwndParent;
This->Tray = (ITrayWindow*)CreateStruct->lpCreateParams;

View file

@ -910,13 +910,11 @@ ITrayBandSiteImpl_Construct(IN OUT ITrayWindow *Tray,
*phwndTaskSwitch = NULL;
This = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*This));
if (This == NULL)
return NULL;
ZeroMemory(This,
sizeof(*This));
This->lpVtbl = &ITrayBandSiteImpl_Vtbl;
This->lpBandSiteVtbl = &IBandSiteImpl_Vtbl;
This->Ref = 1;

View file

@ -615,12 +615,10 @@ CreateSysPagerWnd(IN HWND hWndParent,
HWND hWnd = NULL;
SpData = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*SpData));
if (SpData != NULL)
{
ZeroMemory(SpData, sizeof(*SpData));
/* Create the window. The tray window is going to move it to the correct
position and resize it as needed. */
dwStyle = WS_CHILD | WS_CLIPSIBLINGS;
@ -1357,13 +1355,10 @@ CreateTrayClockWnd(IN HWND hWndParent,
HWND hWnd = NULL;
TcData = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*TcData));
if (TcData != NULL)
{
ZeroMemory(TcData,
sizeof(*TcData));
TcData->IsHorizontal = TRUE;
/* Create the window. The tray window is going to move it to the correct
position and resize it as needed. */
@ -1841,13 +1836,10 @@ CreateTrayNotifyWnd(IN OUT ITrayWindow *TrayWindow,
return NULL;
TnData = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*TnData));
if (TnData != NULL)
{
ZeroMemory(TnData,
sizeof(*TnData));
TnData->TrayWindow = TrayWindow;
TnData->HideClock = bHideClock;

View file

@ -1620,13 +1620,11 @@ ITrayWindowImpl_Construct(VOID)
ITrayWindowImpl *This;
This = HeapAlloc(hProcessHeap,
0,
HEAP_ZERO_MEMORY,
sizeof(*This));
if (This == NULL)
return NULL;
ZeroMemory(This,
sizeof(*This));
This->lpVtbl = &ITrayWindowImpl_Vtbl;
This->lpVtblShellDesktopTray = &IShellDesktopTrayImpl_Vtbl;
This->Ref = 1;