Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-07-08 21:55:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

When doing NtAllocateVirtualMemory, you need to MEM_RELEASE if you intend to

Browse source 
free the memory, otherwise you'll get stray address space hanging around.  This
was noticeable as a leak if you just left the command prompt sitting, because
every DC allocated to blink the cursor kept address space that was never freed.

svn path=/trunk/; revision=30567
This commit is contained in:
Art Yerkes 2007-11-18 23:59:48 +00:00
parent 4ba2b63f3b
commit 74c80e3705
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
reactos/subsystems/win32/win32k/eng/mem.c
View file

@ -102,7 +102,7 @@ EngFreeUserMem(PVOID pv)
PUSERMEMHEADER Header = ((PUSERMEMHEADER) pv) - 1;
ULONG MemSize = sizeof(USERMEMHEADER) + Header->MemSize;
ZwFreeVirtualMemory(NtCurrentProcess(), (PVOID *) &Header, &MemSize, MEM_DECOMMIT);
ZwFreeVirtualMemory(NtCurrentProcess(), (PVOID *) &Header, &MemSize, MEM_RELEASE);
}
/*

2
reactos/subsystems/win32/win32k/ntuser/message.c
View file

@ -887,7 +887,7 @@ NtUserPeekMessage(PNTUSERGETMESSAGEINFO UnsafeInfo,
if (! NT_SUCCESS(Status))
{
ZwFreeVirtualMemory(NtCurrentProcess(), (PVOID *) &UserMem,
&Info.LParamSize, MEM_DECOMMIT);
&Info.LParamSize, MEM_RELEASE);
SetLastNtError(Status);
RETURN( (BOOL) -1);
}

2
reactos/subsystems/win32/win32k/objects/dc.c
View file

@ -2418,7 +2418,7 @@ DC_FreeDcAttr(HDC DCToFree )
NTSTATUS Status = ZwFreeVirtualMemory(Pid,
&Entry->UserData,
&MemSize,
MEM_DECOMMIT);
MEM_RELEASE);
if (NT_SUCCESS(Status))
{
DPRINT("DC_FreeDC DC_ATTR 0x%x\n", Entry->UserData);