Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-01-07 14:51:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

Check if the GetWindowsDirectory call succeeded and use PathAppend to prevent a buffer overflow, when WinDir + "\regedit.exe" > MAX_PATH

Browse source 
svn path=/trunk/; revision=33571
This commit is contained in:
Colin Finck 2008-05-18 10:56:31 +00:00
parent b00f2fbdd7
commit 722735c754
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
reactos/base/applications/regedt32/regedt32.c
View file

@ -1,16 +1,18 @@
#include <windows.h> #include <windows.h>
#include <tchar.h> #include <tchar.h>
#include <shellapi.h> #include <shellapi.h>
#include <shlwapi.h>
int WINAPI _tWinMain(HINSTANCE hCurInst, HINSTANCE hPrevInst, int WINAPI _tWinMain(HINSTANCE hCurInst, HINSTANCE hPrevInst,
LPTSTR lpsCmdLine, int nCmdShow) LPTSTR lpsCmdLine, int nCmdShow)
{ {
TCHAR szPath[MAX_PATH]; TCHAR szPath[MAX_PATH];
GetWindowsDirectory(szPath, MAX_PATH); if(GetWindowsDirectory(szPath, MAX_PATH))
_tcscat(szPath, _T("\\regedit.exe")); {
PathAppend(szPath, _T("regedit.exe"));
ShellExecute(NULL, NULL, szPath, lpsCmdLine, NULL, nCmdShow); ShellExecute(NULL, NULL, szPath, lpsCmdLine, NULL, nCmdShow);
}
return 0; return 0;
} }