Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-03 21:36:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

[TASKMGR] Work around memory leak in performance tab of taskmgr (#8017)

Browse source 
* [TASKMGR] Work around Taskmgr memory leak by changing heap allocation methodology.
CORE-18014
This commit is contained in:
Doug Lyons 2025-06-10 18:04:11 -05:00 • committed by GitHub
parent 3c35117f97
commit 70732b0ca4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

17
base/applications/taskmgr/perfdata.c
View file

@ -64,7 +64,14 @@ BOOL PerfDataInitialize(void)
* Create the SYSTEM Sid * Create the SYSTEM Sid
*/ */
AllocateAndInitializeSid(&NtSidAuthority, 1, SECURITY_LOCAL_SYSTEM_RID, 0, 0, 0, 0, 0, 0, 0, &SystemUserSid); AllocateAndInitializeSid(&NtSidAuthority, 1, SECURITY_LOCAL_SYSTEM_RID, 0, 0, 0, 0, 0, 0, 0, &SystemUserSid);
return TRUE;
/*
* Set up global info storage
*/
SystemProcessorTimeInfo = (PSYSTEM_PROCESSOR_PERFORMANCE_INFORMATION)HeapAlloc(GetProcessHeap(),
0, sizeof(*SystemProcessorTimeInfo) * SystemBasicInfo.NumberOfProcessors);
return SystemProcessorTimeInfo != NULL;
} }
void PerfDataUninitialize(void) void PerfDataUninitialize(void)
@ -247,10 +254,12 @@ void PerfDataRefresh(void)
/* /*
* Save system processor time info * Save system processor time info
*/ */
if (SystemProcessorTimeInfo) { memcpy(SystemProcessorTimeInfo, SysProcessorTimeInfo,
HeapFree(GetProcessHeap(), 0, SystemProcessorTimeInfo); sizeof(*SystemProcessorTimeInfo) * SystemBasicInfo.NumberOfProcessors);
if (SysProcessorTimeInfo) {
HeapFree(GetProcessHeap(), 0, SysProcessorTimeInfo);
} }
SystemProcessorTimeInfo = SysProcessorTimeInfo;
/* /*
* Save system handle info * Save system handle info