Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-27 09:34:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTUSER] Increase desktop heap size

Browse source 
Distinguish between the following 3 scenarios:
1. Interactive Winsta0, "Winlogon" desktop: use 128 KB
2. Interactive Winsta0, "Default" & other desktop: use 3 MB (x86) / 20 MB (x64)
3. Non-interactive winsta: use 128 KB

This is what Windows 2003 uses for the interactive desktops on x86 and what Windows 7 uses for x64. Fixes desktop heap exhaustion during testing. The previous value was 512 KB for all desktops.
It doesn't handle the even smaller "Disconnected" desktop, which is only meaningful for RDP sessions and we don't use it anyway.
See comments in the file for references.
This commit is contained in:
Timo Kreuzer 2024-09-03 22:52:35 +03:00
parent bc76250bd8
commit 6ca6088f2c
1 changed files with 40 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
win32ss/user/ntuser/desktop.c
View file

@ -27,9 +27,26 @@ IntFreeDesktopHeap(IN PDESKTOP pdesk);
/* GLOBALS *******************************************************************/ /* GLOBALS *******************************************************************/
/* These can be changed via CSRSS startup, these are defaults */ /* These can be changed via registry settings.
DWORD gdwDesktopSectionSize = 512; * Default values (interactive desktop / non-interactive desktop):
DWORD gdwNOIOSectionSize = 128; // A guess, for one or more of the first three system desktops. * Windows 2003 x86: 3 MB / 512 KB (Disconnect: 64 KB, Winlogon: 128 KB)
* Windows 7 x86: 12 MB / 512 KB
* Windows 7 x64: 20 MB / 768 KB
* Windows 10 x64: 20 MB / 4 MB
* See:
* - https://dbmentors.blogspot.com/2011/09/desktop-heap-overview.html
* - https://www.ibm.com/support/pages/using-microsoft-desktop-heap-monitor-dheapmon-determine-desktop-heap-space-and-troubleshoot-filenet-p8-and-image-services-issues
* - https://www.betaarchive.com/wiki/index.php?title=Microsoft_KB_Archive/184802
* - https://kb.firedaemon.com/support/solutions/articles/4000086192-windows-service-quota-limits-and-desktop-heap-exhaustion
* - https://learn.microsoft.com/en-us/troubleshoot/windows-server/performance/desktop-heap-limitation-out-of-memory
*/
#ifdef _WIN64
DWORD gdwDesktopSectionSize = 20 * 1024; // 20 MB (Windows 7 style)
#else
DWORD gdwDesktopSectionSize = 3 * 1024; // 3 MB (Windows 2003 style)
#endif
DWORD gdwNOIOSectionSize = 128;
DWORD gdwWinlogonSectionSize = 128;
/* Currently active desktop */ /* Currently active desktop */
PDESKTOP gpdeskInputDesktop = NULL; PDESKTOP gpdeskInputDesktop = NULL;
@ -2259,8 +2276,9 @@ IntPaintDesktop(HDC hDC)
static NTSTATUS static NTSTATUS
UserInitializeDesktop(PDESKTOP pdesk, PUNICODE_STRING DesktopName, PWINSTATION_OBJECT pwinsta) UserInitializeDesktop(PDESKTOP pdesk, PUNICODE_STRING DesktopName, PWINSTATION_OBJECT pwinsta)
{ {
static const UNICODE_STRING WinlogonDesktop = RTL_CONSTANT_STRING(L"Winlogon");
PVOID DesktopHeapSystemBase = NULL; PVOID DesktopHeapSystemBase = NULL;
ULONG_PTR HeapSize = gdwDesktopSectionSize * 1024; ULONG_PTR HeapSize;
SIZE_T DesktopInfoSize; SIZE_T DesktopInfoSize;
ULONG i; ULONG i;
@ -2268,6 +2286,24 @@ UserInitializeDesktop(PDESKTOP pdesk, PUNICODE_STRING DesktopName, PWINSTATION_O
RtlZeroMemory(pdesk, sizeof(DESKTOP)); RtlZeroMemory(pdesk, sizeof(DESKTOP));
/* Set desktop size, based on whether the WinSta is interactive or not */
if (pwinsta == InputWindowStation)
{
/* Check if the Desktop is named "Winlogon" */
if (RtlEqualUnicodeString(DesktopName, &WinlogonDesktop, TRUE))
{
HeapSize = gdwWinlogonSectionSize * 1024;
}
else
{
HeapSize = gdwDesktopSectionSize * 1024;
}
}
else
{
HeapSize = gdwNOIOSectionSize * 1024;
}
/* Link the desktop with the parent window station */ /* Link the desktop with the parent window station */
ObReferenceObject(pwinsta); ObReferenceObject(pwinsta);
pdesk->rpwinstaParent = pwinsta; pdesk->rpwinstaParent = pwinsta;