From 6bd9e7bed6f0aeaf281b4d84027eb5c6d520e1a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Thu, 6 Sep 2007 08:25:57 +0000 Subject: [PATCH] Explain why some binutils are blacklisted svn path=/trunk/; revision=28895 --- reactos/tools/rbuild/backend/mingw/mingw.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/reactos/tools/rbuild/backend/mingw/mingw.cpp b/reactos/tools/rbuild/backend/mingw/mingw.cpp index 9bb749fa0e4..64fe6d33207 100644 --- a/reactos/tools/rbuild/backend/mingw/mingw.cpp +++ b/reactos/tools/rbuild/backend/mingw/mingw.cpp @@ -890,14 +890,20 @@ bool MingwBackend::IsSupportedBinutilsVersion ( const string& binutilsVersion ) { if ( manualBinutilsSetting ) return true; - + /* linux */ if ( binutilsVersion.find('.') != std::string::npos ) { - /* TODO: blacklist versions on version number instead of date */ + /* TODO: blacklist versions on version number instead of date */ return true; } + /* + * - Binutils older than 2003/10/01 have broken windres which can't handle + * icons with alpha channel. + * - Binutils between 2004/09/02 and 2004/10/08 have broken handling of + * forward exports in dlltool. + */ if ( ( ( strcmp ( binutilsVersion.c_str (), "20040902") >= 0 ) && ( strcmp ( binutilsVersion.c_str (), "20041008") <= 0 ) ) || ( strcmp ( binutilsVersion.c_str (), "20031001") < 0 ) )