Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-06 06:02:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SERVICES]

Browse source 
- On service stop, set Service->lpImage to NULL after calling ScmDereferenceServiceImage, so the same image is not dereferenced again on service deletion
- Do not call ScmDereferenceServiceImage in CreateServiceListEntry, as the service should never have an image there
CORE-11273 #resolve

svn path=/trunk/; revision=71355
This commit is contained in:
Thomas Faber 2016-05-19 13:01:04 +00:00
parent 407f2e8218
commit 6b27b08a69
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
reactos/base/system/services/database.c
View file

@ -566,8 +566,7 @@ done:;
if (lpService != NULL) if (lpService != NULL)
{ {
if (lpService->lpImage != NULL) ASSERT(lpService->lpImage == NULL);
ScmDereferenceServiceImage(lpService->lpImage);
} }
return dwError; return dwError;
@ -1085,6 +1084,7 @@ Done:
dwControl == SERVICE_CONTROL_STOP) dwControl == SERVICE_CONTROL_STOP)
{ {
ScmDereferenceServiceImage(Service->lpImage); ScmDereferenceServiceImage(Service->lpImage);
Service->lpImage = NULL;
} }
LeaveCriticalSection(&ControlServiceCriticalSection); LeaveCriticalSection(&ControlServiceCriticalSection);