Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-02 05:45:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

[HEAP]

Browse source 
- RtlpInsertFreeBlockHelper: Don't validate the Previous Size of the next Heap Entry when inserting a free Heap Entry into a free list. Should solve bug #5843 and may affect bug #5857.
  All callers of this function already perform this check, except for RtlpInsertFreeBlock, a function used during Heap Segment creation/expansion.
  RtlpInsertFreeBlock creates multiple free Heap Entries (using the helper function) if the free space is too big to be contained in a single Heap Entry.
  In such a case however, it creates a Heap Entry and calls the helper before creating the next Heap Entry, which triggers this assert.

svn path=/trunk/; revision=50617
This commit is contained in:
Roel Messiant 2011-02-08 06:06:33 +00:00
parent 6b67a4985e
commit 67f749a33b
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
reactos/lib/rtl/heap.c
View file

@ -235,12 +235,6 @@ RtlpInsertFreeBlockHelper(PHEAP Heap,
FreeEntry->Flags &= HEAP_ENTRY_LAST_ENTRY; FreeEntry->Flags &= HEAP_ENTRY_LAST_ENTRY;
} }
/* Check if PreviousSize of the next entry matches ours */
if (!(FreeEntry->Flags & HEAP_ENTRY_LAST_ENTRY))
{
ASSERT(((PHEAP_ENTRY)FreeEntry + BlockSize)->PreviousSize == BlockSize);
}
/* Insert it either into dedicated or non-dedicated list */ /* Insert it either into dedicated or non-dedicated list */
if (BlockSize < HEAP_FREELISTS) if (BlockSize < HEAP_FREELISTS)
{ {