Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-05 15:02:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

Optimize GetClassLongA/W to read most information from the desktop heap

Browse source 
svn path=/trunk/; revision=30491
This commit is contained in:
Thomas Bluemel 2007-11-16 03:02:38 +00:00
parent fdb8bd5a53
commit 6687385c3b
1 changed files with 164 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

190
reactos/dll/win32/user32/windows/class.c
View file

@ -203,21 +203,90 @@ GetClassInfoW(
DWORD STDCALL DWORD STDCALL
GetClassLongA(HWND hWnd, int nIndex) GetClassLongA(HWND hWnd, int nIndex)
{ {
TRACE("%p %d\n", hWnd, nIndex); PWINDOW Wnd;
PWINDOWCLASS Class;
ULONG_PTR Ret = 0;
switch (nIndex) TRACE("%p %d\n", hWnd, nIndex);
{
case GCL_HBRBACKGROUND:
{
DWORD hBrush = NtUserGetClassLong(hWnd, GCL_HBRBACKGROUND, TRUE);
if (hBrush != 0 && hBrush < 0x4000)
hBrush = (DWORD)GetSysColorBrush((ULONG)hBrush - 1);
return hBrush;
}
default: Wnd = ValidateHwnd(hWnd);
return NtUserGetClassLong(hWnd, nIndex, TRUE); if (!Wnd)
} return 0;
Class = DesktopPtrToUser(Wnd->Class);
ASSERT(Class != NULL);
if (nIndex >= 0)
{
if (nIndex + sizeof(ULONG_PTR) < nIndex ||
nIndex + sizeof(ULONG_PTR) > Class->ClsExtra)
{
SetLastError(ERROR_INVALID_PARAMETER);
return 0;
}
Ret = *(PULONG_PTR)((ULONG_PTR)(Class + 1) + nIndex);
}
else
{
switch (nIndex)
{
case GCL_CBWNDEXTRA:
Ret = (ULONG_PTR)Class->WndExtra;
break;
case GCL_CBCLSEXTRA:
Ret = (ULONG_PTR)Class->ClsExtra;
break;
case GCL_HBRBACKGROUND:
Ret = (ULONG_PTR)Class->hbrBackground;
if (Ret != 0 && Ret < 0x4000)
Ret = (ULONG_PTR)GetSysColorBrush((ULONG)Ret - 1);
break;
case GCL_HMODULE:
Ret = (ULONG_PTR)Class->hInstance;
break;
case GCL_MENUNAME:
Ret = (ULONG_PTR)Class->AnsiMenuName;
break;
case GCL_STYLE:
Ret = (ULONG_PTR)Class->Style;
break;
case GCW_ATOM:
Ret = (ULONG_PTR)Class->Atom;
break;
case GCLP_HCURSOR:
/* FIXME - get handle from pointer to CURSOR object */
Ret = (ULONG_PTR)Class->hCursor;
break;
case GCLP_HICON:
/* FIXME - get handle from pointer to ICON object */
Ret = (ULONG_PTR)Class->hIcon;
break;
case GCLP_HICONSM:
/* FIXME - get handle from pointer to ICON object */
Ret = (ULONG_PTR)Class->hIconSm;
break;
case GCLP_WNDPROC:
/* We need to make a call to win32k as it may be required to
create a callproc handle */
return NtUserGetClassLong(hWnd, nIndex, TRUE);
default:
SetLastError(ERROR_INVALID_INDEX);
}
}
return Ret;
} }
/* /*
@ -226,21 +295,90 @@ GetClassLongA(HWND hWnd, int nIndex)
DWORD STDCALL DWORD STDCALL
GetClassLongW ( HWND hWnd, int nIndex ) GetClassLongW ( HWND hWnd, int nIndex )
{ {
TRACE("%p %d\n", hWnd, nIndex); PWINDOW Wnd;
PWINDOWCLASS Class;
ULONG_PTR Ret = 0;
switch (nIndex) TRACE("%p %d\n", hWnd, nIndex);
{
case GCL_HBRBACKGROUND:
{
DWORD hBrush = NtUserGetClassLong(hWnd, GCL_HBRBACKGROUND, TRUE);
if (hBrush != 0 && hBrush < 0x4000)
hBrush = (DWORD)GetSysColorBrush((ULONG)hBrush - 1);
return hBrush;
}
default: Wnd = ValidateHwnd(hWnd);
return NtUserGetClassLong(hWnd, nIndex, FALSE); if (!Wnd)
} return 0;
Class = DesktopPtrToUser(Wnd->Class);
ASSERT(Class != NULL);
if (nIndex >= 0)
{
if (nIndex + sizeof(ULONG_PTR) < nIndex ||
nIndex + sizeof(ULONG_PTR) > Class->ClsExtra)
{
SetLastError(ERROR_INVALID_PARAMETER);
return 0;
}
Ret = *(PULONG_PTR)((ULONG_PTR)(Class + 1) + nIndex);
}
else
{
switch (nIndex)
{
case GCL_CBWNDEXTRA:
Ret = (ULONG_PTR)Class->WndExtra;
break;
case GCL_CBCLSEXTRA:
Ret = (ULONG_PTR)Class->ClsExtra;
break;
case GCL_HBRBACKGROUND:
Ret = (ULONG_PTR)Class->hbrBackground;
if (Ret != 0 && Ret < 0x4000)
Ret = (ULONG_PTR)GetSysColorBrush((ULONG)Ret - 1);
break;
case GCL_HMODULE:
Ret = (ULONG_PTR)Class->hInstance;
break;
case GCL_MENUNAME:
Ret = (ULONG_PTR)Class->MenuName;
break;
case GCL_STYLE:
Ret = (ULONG_PTR)Class->Style;
break;
case GCW_ATOM:
Ret = (ULONG_PTR)Class->Atom;
break;
case GCLP_HCURSOR:
/* FIXME - get handle from pointer to CURSOR object */
Ret = (ULONG_PTR)Class->hCursor;
break;
case GCLP_HICON:
/* FIXME - get handle from pointer to ICON object */
Ret = (ULONG_PTR)Class->hIcon;
break;
case GCLP_HICONSM:
/* FIXME - get handle from pointer to ICON object */
Ret = (ULONG_PTR)Class->hIconSm;
break;
case GCLP_WNDPROC:
/* We need to make a call to win32k as it may be required to
create a callproc handle */
return NtUserGetClassLong(hWnd, nIndex, FALSE);
default:
SetLastError(ERROR_INVALID_INDEX);
}
}
return Ret;
} }