diff --git a/reactos/hal/halx86/generic/cmos.c b/reactos/hal/halx86/generic/cmos.c index 14cd589b0e5..afc698e7034 100644 --- a/reactos/hal/halx86/generic/cmos.c +++ b/reactos/hal/halx86/generic/cmos.c @@ -19,8 +19,8 @@ KSPIN_LOCK HalpSystemHardwareLock; /* PRIVATE FUNCTIONS *********************************************************/ -UCHAR FORCEINLINE +UCHAR HalpReadCmos(IN UCHAR Reg) { /* Select the register */ @@ -30,8 +30,8 @@ HalpReadCmos(IN UCHAR Reg) return READ_PORT_UCHAR(CMOS_DATA_PORT); } -VOID FORCEINLINE +VOID HalpWriteCmos(IN UCHAR Reg, IN UCHAR Value) { diff --git a/reactos/hal/halx86/generic/dma.c b/reactos/hal/halx86/generic/dma.c index 82e40cb7b4a..e664cf90cfe 100644 --- a/reactos/hal/halx86/generic/dma.c +++ b/reactos/hal/halx86/generic/dma.c @@ -1073,7 +1073,7 @@ HalAllocateAdapterChannel( { PADAPTER_OBJECT MasterAdapter; PGROW_WORK_ITEM WorkItem; - ULONG Index = ~0; + ULONG Index = ~0U; ULONG Result; KIRQL OldIrql; @@ -1129,7 +1129,7 @@ HalAllocateAdapterChannel( { Index = RtlFindClearBitsAndSet( MasterAdapter->MapRegisters, NumberOfMapRegisters, 0); - if (Index != ~0) + if (Index != ~0U) { AdapterObject->MapRegisterBase = MasterAdapter->MapRegisterBase + Index; @@ -1143,7 +1143,7 @@ HalAllocateAdapterChannel( } } - if (Index == ~0) + if (Index == ~0U) { WorkItem = ExAllocatePoolWithTag( NonPagedPool, sizeof(GROW_WORK_ITEM), TAG_DMA); @@ -1287,7 +1287,7 @@ IoFreeAdapterChannel( Index = RtlFindClearBitsAndSet( MasterAdapter->MapRegisters, WaitContextBlock->NumberOfMapRegisters, 0); - if (Index != ~0) + if (Index != ~0U) { AdapterObject->MapRegisterBase = MasterAdapter->MapRegisterBase + Index; @@ -1301,7 +1301,7 @@ IoFreeAdapterChannel( } } - if (Index == ~0) + if (Index == ~0U) { InsertTailList(&MasterAdapter->AdapterQueue, &AdapterObject->AdapterQueue); KfReleaseSpinLock(&MasterAdapter->SpinLock, OldIrql); @@ -1404,7 +1404,7 @@ IoFreeMapRegisters( MasterAdapter->MapRegisters, AdapterObject->NumberOfMapRegisters, MasterAdapter->NumberOfMapRegisters); - if (Index == ~0) + if (Index == ~0U) { InsertHeadList(&MasterAdapter->AdapterQueue, ListEntry); break; @@ -1602,7 +1602,7 @@ IoFlushAdapterBuffers( { if ((ULONG_PTR)MapRegisterBase & MAP_BASE_SW_SG) { - if (RealMapRegisterBase->Counter != ~0) + if (RealMapRegisterBase->Counter != ~0U) { if (SlaveDma && !AdapterObject->IgnoreCount) Length -= HalReadDmaCounter(AdapterObject); @@ -1984,13 +1984,12 @@ HalAllocateCrashDumpRegisters(IN PADAPTER_OBJECT AdapterObject, } /* Try to find free map registers */ - MapRegisterNumber = -1; MapRegisterNumber = RtlFindClearBitsAndSet(MasterAdapter->MapRegisters, *NumberOfMapRegisters, 0); /* Check if nothing was found */ - if (MapRegisterNumber == -1) + if (MapRegisterNumber == -1U) { /* No free registers found, so use the base registers */ RtlSetBits(MasterAdapter->MapRegisters, diff --git a/reactos/hal/halx86/generic/pci.c b/reactos/hal/halx86/generic/pci.c index 9bdabddb812..c7f6e222c5c 100644 --- a/reactos/hal/halx86/generic/pci.c +++ b/reactos/hal/halx86/generic/pci.c @@ -81,10 +81,10 @@ PCIPBUSDATA HalpFakePciBusData = HalpWritePCIConfig, NULL, NULL, - {{{0}}}, + {{{0, 0, 0}}}, {0, 0, 0, 0} }, - {{0}}, + {{0, 0}}, 32, }; diff --git a/reactos/hal/halx86/generic/reboot.c b/reactos/hal/halx86/generic/reboot.c index bac0b4153ec..c9a1219c2c9 100644 --- a/reactos/hal/halx86/generic/reboot.c +++ b/reactos/hal/halx86/generic/reboot.c @@ -29,7 +29,7 @@ HalpReboot(VOID) { UCHAR Data; PVOID HalpZeroPageMapping; - PHYSICAL_ADDRESS Null = {{0}}; + PHYSICAL_ADDRESS Null = {{0, 0}}; /* Enable warm reboot */ HalpZeroPageMapping = MmMapIoSpace(Null, PAGE_SIZE, MmNonCached);