Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-31 06:58:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

[UNIATA] Fix memory corruption if SCSIOP_SERVICE_ACTION16 processed. (#7717)

Browse source 
Reason: the size of `READ_CAPACITY16_DATA` struct in UniATA driver and ReactOS/Windows SDK were not equal.

- In UniATA driver: `sizeof(READ_CAPACITY16_DATA) == 33` (wrong);
- In ReactOS/Windows SDK: `sizeof(READ_CAPACITY16_DATA) == 32` (correct).

CORE-19696
This commit is contained in:
Max Korostil 2025-03-02 21:07:34 +03:00 committed by GitHub
parent e36c669d97
commit 606e996e1f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/storage/ide/uniata/scsi.h
View file

@ -1433,7 +1433,13 @@ typedef struct _READ_CAPACITY16_DATA {
UCHAR Prot_EN:1; UCHAR Prot_EN:1;
UCHAR RTO_EN:1; UCHAR RTO_EN:1;
UCHAR Reserved:6; UCHAR Reserved:6;
#ifdef __REACTOS__
/* In ReactOS SDK sizeof(READ_CAPACITY16_DATA) == 32.
* Fixes CORE-19696 memory corruption on SCSIOP_SERVICE_ACTION16. */
UCHAR Reserved1[19];
#else
UCHAR Reserved1[20]; UCHAR Reserved1[20];
#endif
} READ_CAPACITY16_DATA, *PREAD_CAPACITY16_DATA; } READ_CAPACITY16_DATA, *PREAD_CAPACITY16_DATA;
// CD ROM Read Table Of Contents (TOC) structures // CD ROM Read Table Of Contents (TOC) structures