Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-26 08:30:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

[KMTESTS:KE] Correctly handle MP builds in KeSpinLock test.

Browse source
This commit is contained in:
Thomas Faber 2023-01-28 21:54:05 -05:00
parent 2f63da62e3
commit 5f1fff696b
No known key found for this signature in database
GPG key ID: 076E7C3D44720826
1 changed files with 28 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
modules/rostests/kmtests/ntos_ke/KeSpinLock.c
View file

@ -1,8 +1,9 @@
/* /*
* PROJECT: ReactOS kernel-mode tests * PROJECT: ReactOS kernel-mode tests
* LICENSE: GPLv2+ - See COPYING in the top level directory * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later)
* PURPOSE: Kernel-Mode Test Suite Spin lock test * PURPOSE: Kernel-Mode Test Suite Spin lock test
* PROGRAMMER: Thomas Faber <thomas.faber@reactos.org> * COPYRIGHT: Copyright 2011-2023 Thomas Faber (thomas.faber@reactos.org)
* COPYRIGHT: Copyright 2021 Jérôme Gardou (jerome.gardou@reactos.org)
*/ */
#ifndef _WIN64 #ifndef _WIN64
@ -265,13 +266,21 @@ TestSpinLock(
CheckSpinLock(SpinLock, CheckData, 0); CheckSpinLock(SpinLock, CheckData, 0);
ok_bool_true(CheckData->TryAcquire(SpinLock, CheckData), "TryAcquire returned"); ok_bool_true(CheckData->TryAcquire(SpinLock, CheckData), "TryAcquire returned");
CheckSpinLock(SpinLock, CheckData, 1); CheckSpinLock(SpinLock, CheckData, 1);
/* A second TryToAcquire results in SPINLOCK_ALREADY_OWNED on checked builds */
if (!KmtIsCheckedBuild) if (!KmtIsCheckedBuild)
{ {
/* SPINLOCK_ALREADY_OWNED on checked build */ if (KmtIsMultiProcessorBuild)
ok_bool_true(CheckData->TryAcquire(SpinLock, CheckData), "TryAcquire returned"); {
/* even a failing acquire sets irql */ /* In MP, this fails as you would expect */
ok_eq_uint(CheckData->Irql, CheckData->IrqlWhenAcquired); ok_bool_false(CheckData->TryAcquire(SpinLock, CheckData), "TryAcquire returned");
CheckData->Irql = CheckData->OriginalIrql; }
else
{
/* In UP, this always succeeds: recursive acquires are illegal and parallel processors don't exist */
ok_bool_true(CheckData->TryAcquire(SpinLock, CheckData), "TryAcquire returned");
ok_eq_uint(CheckData->Irql, CheckData->IrqlWhenAcquired);
CheckData->Irql = CheckData->OriginalIrql;
}
CheckSpinLock(SpinLock, CheckData, 1); CheckSpinLock(SpinLock, CheckData, 1);
} }
CheckData->Release(SpinLock, CheckData); CheckData->Release(SpinLock, CheckData);
@ -312,7 +321,16 @@ TestSpinLock(
CheckSpinLock(SpinLock, CheckData, 1); CheckSpinLock(SpinLock, CheckData, 1);
if (!KmtIsCheckedBuild) if (!KmtIsCheckedBuild)
{ {
ok_bool_true(CheckData->TryAcquireNoRaise(SpinLock, CheckData), "TryAcquireNoRaise returned"); if (KmtIsMultiProcessorBuild)
{
/* In MP, this fails as you would expect */
ok_bool_false(CheckData->TryAcquireNoRaise(SpinLock, CheckData), "TryAcquireNoRaise returned");
}
else
{
/* In UP, this always succeeds: recursive acquires are illegal and parallel processors don't exist */
ok_bool_true(CheckData->TryAcquireNoRaise(SpinLock, CheckData), "TryAcquireNoRaise returned");
}
CheckSpinLock(SpinLock, CheckData, 1); CheckSpinLock(SpinLock, CheckData, 1);
} }
CheckData->ReleaseNoLower(SpinLock, CheckData); CheckData->ReleaseNoLower(SpinLock, CheckData);