Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-02 14:06:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

[WINESYNC] msi: Don't check the primary keys when handling MSIMODIFY_DELETE.

Browse source 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 96b6d6b58725f17f3faabeeffe82d2b8bd5f0445 by Zebediah Figura <z.figura12@gmail.com>
This commit is contained in:
winesync 2022-03-13 00:16:39 +01:00 • committed by Mark Jansen
parent 17ae3a2dd9
commit 5f1570f47d
No known key found for this signature in database
GPG key ID: B39240EE84BEAE8B
2 changed files with 2 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

14
dll/win32/msi/table.c
View file

@ -1835,18 +1835,6 @@ static UINT msi_table_assign(struct tagMSIVIEW *view, MSIRECORD *rec)
return TABLE_insert_row( view, rec, -1, FALSE );
}
static UINT modify_delete_row( struct tagMSIVIEW *view, MSIRECORD *rec )
{
MSITABLEVIEW *tv = (MSITABLEVIEW *)view;
UINT row, r;
r = msi_table_find_row(tv, rec, &row, NULL);
if (r != ERROR_SUCCESS)
return r;
return TABLE_delete_row(view, row);
}
static UINT msi_refresh_record( struct tagMSIVIEW *view, MSIRECORD *rec, UINT row )
{
MSIRECORD *curr;
@ -1878,7 +1866,7 @@ static UINT TABLE_modify( struct tagMSIVIEW *view, MSIMODIFY eModifyMode,
switch (eModifyMode)
{
case MSIMODIFY_DELETE:
r = modify_delete_row( view, rec );
r = TABLE_delete_row( view, row );
break;
case MSIMODIFY_VALIDATE_NEW:
r = table_validate_new( tv, rec, &column );

1
modules/rostests/winetests/msi/db.c
View file

@ -5498,6 +5498,7 @@ static void test_viewmodify_delete(void)
ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r);
/* delete 2 */
MsiRecordSetInteger(hrec, 1, 4);
r = MsiViewModify(hview, MSIMODIFY_DELETE, hrec);
ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r);