From 5db69da46b09b98cf382864cfc4f9967d8d6dbad Mon Sep 17 00:00:00 2001 From: Whindmar Saksit Date: Sun, 12 May 2024 00:07:54 +0200 Subject: [PATCH] [RAPPS] DelRegEmpty instruction should be best-effort, don't propagate any errors (#6860) DelRegEmpty exists to clean up "company" registry parent keys. If another application is writing to the key at the same time as we are gently trying to remove it, our uninstaller should ignore any errors. --- base/applications/rapps/geninst.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/applications/rapps/geninst.cpp b/base/applications/rapps/geninst.cpp index d304eb24eb7..d7cc3a678e0 100644 --- a/base/applications/rapps/geninst.cpp +++ b/base/applications/rapps/geninst.cpp @@ -752,7 +752,7 @@ UninstallThread(LPVOID Parameter) if (op == UNOP_REGKEY) err = key.RecurseDeleteKey(tmp); else if (RegKeyHasValues(hKey, str, wowsam) == S_FALSE) - err = key.DeleteSubKey(tmp); + key.DeleteSubKey(tmp); // DelRegEmpty ignores errors } switch(err) {