From 5cb1fd2dda83986c4feb22d37dc6ec498727af5e Mon Sep 17 00:00:00 2001 From: Dmitry Chapyshev Date: Mon, 1 Aug 2016 11:29:01 +0000 Subject: [PATCH] [SHELL32] - Fixed memory leak [DNSLIB] - Fixed uninitialized variable [USERENV] - Fixed typo svn path=/trunk/; revision=72070 --- reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp | 1 + reactos/dll/win32/userenv/environment.c | 2 +- reactos/sdk/lib/dnslib/straddr.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp b/reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp index e521b875a29..844911eae39 100644 --- a/reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp +++ b/reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp @@ -179,6 +179,7 @@ static CDesktopBrowser *SHDESK_Create(HWND hWnd, LPCREATESTRUCT lpCreateStruct) if (FAILED(hRet)) { pThis->Release(); + delete pThis; return NULL; } diff --git a/reactos/dll/win32/userenv/environment.c b/reactos/dll/win32/userenv/environment.c index fa319d3c4e7..9b434d92889 100644 --- a/reactos/dll/win32/userenv/environment.c +++ b/reactos/dll/win32/userenv/environment.c @@ -463,7 +463,7 @@ CreateEnvironmentBlock(LPVOID *lpEnvironment, FALSE); } - /* Set variables from System Manager */ + /* Set variables from Session Manager */ SetUserEnvironment(lpEnvironment, HKEY_LOCAL_MACHINE, L"System\\CurrentControlSet\\Control\\Session Manager\\Environment"); diff --git a/reactos/sdk/lib/dnslib/straddr.c b/reactos/sdk/lib/dnslib/straddr.c index 4215a80dbf0..d503ae5e9e6 100644 --- a/reactos/sdk/lib/dnslib/straddr.c +++ b/reactos/sdk/lib/dnslib/straddr.c @@ -170,7 +170,7 @@ Dns_StringToAddressEx(OUT PVOID Address, ULONG AddrSize = *AddressSize; IN6_ADDR Addr; BOOLEAN Return; - INT ErrorCode; + INT ErrorCode = ERROR_SUCCESS; CHAR AnsiName[INET6_ADDRSTRLEN + sizeof("ip6.arpa.")]; ULONG Size = sizeof(AnsiName);