Bug fixes against uninitizlied variables and support for tree-wide optimization (do not try yet, crashes in bootvid).

svn path=/trunk/; revision=13130
This commit is contained in:
Alex Ionescu 2005-01-19 03:33:43 +00:00
parent dfb0ecac30
commit 5b90245c50
15 changed files with 25 additions and 32 deletions

View file

@ -30,7 +30,7 @@ DBG := 0
#
# Whether to compile with optimizations
#
OPTIMIZED := 0
OPTIMIZED := 0
#
# Whether to compile a multiprocessor or single processor version

View file

@ -59,7 +59,7 @@ VOID DGDeliverData(
if (!IsListEmpty(&AddrFile->ReceiveQueue))
{
PLIST_ENTRY CurrentEntry;
PDATAGRAM_RECEIVE_REQUEST Current;
PDATAGRAM_RECEIVE_REQUEST Current = NULL;
BOOLEAN Found;
PTA_IP_ADDRESS RTAIPAddress;

View file

@ -41,7 +41,7 @@ NTSTATUS WarmSocketForConnection( PAFD_FCB FCB ) {
}
NTSTATUS MakeSocketIntoConnection( PAFD_FCB FCB ) {
NTSTATUS Status;
NTSTATUS Status = STATUS_NO_MEMORY;
/* Allocate the receive area and start receiving */
FCB->Recv.Window =

View file

@ -22,7 +22,7 @@ NTSTATUS DDKAPI SendComplete
PLIST_ENTRY NextIrpEntry;
PIRP NextIrp = NULL;
PIO_STACK_LOCATION NextIrpSp;
PAFD_SEND_INFO SendReq;
PAFD_SEND_INFO SendReq = NULL;
PAFD_MAPBUF Map;
UINT TotalBytesCopied = 0, SpaceAvail, i, CopySize = 0;

View file

@ -129,10 +129,10 @@ TDI_STATUS InfoTdiQueryInformationEx(
{
KIRQL OldIrql;
UINT i;
PVOID context;
PVOID context = NULL;
NTSTATUS Status = STATUS_SUCCESS;
BOOL FoundEntity = FALSE;
InfoRequest_f InfoRequest;
InfoRequest_f InfoRequest = NULL;
TI_DbgPrint(MAX_TRACE,
("InfoEx Req: %x %x %x!%04x:%d\n",

View file

@ -121,7 +121,7 @@ HalGetAdapter (PDEVICE_DESCRIPTION DeviceDescription,
DWORD ChannelSelect;
DWORD Controller;
ULONG MaximumLength;
BOOLEAN ChannelSetup;
BOOLEAN ChannelSetup = FALSE;
DMA_MODE DmaMode;
DPRINT("Entered Function\n");

View file

@ -67,7 +67,7 @@ NTSTATUS NTAPI
PsaCaptureSystemModules(OUT PSYSTEM_MODULE_INFORMATION *SystemModules)
{
SIZE_T nSize = 0;
PSYSTEM_MODULE_INFORMATION psmModules;
PSYSTEM_MODULE_INFORMATION psmModules = NULL;
NTSTATUS Status;
#if 0
@ -94,7 +94,7 @@ PsaCaptureSystemModules(OUT PSYSTEM_MODULE_INFORMATION *SystemModules)
pool/heap, we try to determine the buffer size in advance, knowing that
the number of elements is unlikely to change */
nSize = sizeof(SYSTEM_MODULE_INFORMATION) +
((psmModules->Count - 1) * sizeof(SYSTEM_MODULE_INFORMATION));
(nSize * sizeof(SYSTEM_MODULE_INFORMATION));
psmModules = NULL;

View file

@ -66,7 +66,7 @@ WSPSocket(
PHELPER_DATA HelperData;
PVOID HelperDLLContext;
DWORD HelperEvents;
DWORD IOOptions;
DWORD IOOptions = 0;
UNICODE_STRING TransportName;
UNICODE_STRING DevName;
LARGE_INTEGER GroupData;
@ -728,8 +728,8 @@ WSPAccept(
NTSTATUS Status;
struct fd_set ReadSet;
struct timeval Timeout;
PVOID PendingData;
ULONG PendingDataLength;
PVOID PendingData = NULL;
ULONG PendingDataLength = 0;
PVOID CalleeDataBuffer;
WSABUF CallerData, CalleeID, CallerID, CalleeData;
PSOCKADDR RemoteAddress = NULL;

View file

@ -860,7 +860,7 @@ RegisterPropSheetHandler(LPTSTR szType, LPWSTR szGuid)
HRESULT STDCALL
DllRegisterServer(VOID)
{
LONG e;
LONG e = E_ACCESSDENIED;
HKEY hk;
WCHAR szGuid[40];
WCHAR szDescription[255];

View file

@ -7,6 +7,7 @@
* REVISIONS:
* CSH 01/09-2000 Created
*/
#define __NO_CTYPE_INLINES
#include <ctype.h>
#include <ws2_32.h>
#include <winbase.h>

View file

@ -26,12 +26,6 @@ endif
LINKER_SCRIPT := ntoskrnl.lnk
STRIP_FLAGS := -Wl,-s
ifeq ($(OPTIMIZED), 1)
CFLAGS_OPT := -O2 -Wno-strict-aliasing
else
CFLAGS_OPT :=
endif
ifeq ($(KDBG), 1)
OBJECTS_KDBG := dbg/kdb.o dbg/kdb_serial.o dbg/kdb_keyboard.o dbg/rdebug.o \
dbg/i386/kdb_help.o \

View file

@ -206,7 +206,7 @@ static inline PVOID
FrameworkGetFunction(PAPI_DESCRIPTION ApiDescription)
{
HANDLE hModule;
PVOID function;
PVOID function = NULL;
PCHAR exportedFunctionName;
exportedFunctionName = FrameworkGetExportedFunctionNameInternal(ApiDescription);

View file

@ -737,7 +737,7 @@ GuiConsoleRightMouseDown(HWND hWnd)
static LRESULT CALLBACK
GuiConsoleWndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
LRESULT Result;
LRESULT Result = 0;
switch(msg)
{
@ -746,7 +746,6 @@ GuiConsoleWndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam)
break;
case WM_PAINT:
GuiConsoleHandlePaint(hWnd);
Result = 0;
break;
case WM_KEYDOWN:
case WM_KEYUP:
@ -754,19 +753,15 @@ GuiConsoleWndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam)
case WM_SYSKEYUP:
case WM_CHAR:
GuiConsoleHandleKey(hWnd, msg, wParam, lParam);
Result = 0;
break;
case WM_TIMER:
GuiConsoleHandleTimer(hWnd);
Result = 0;
break;
case WM_CLOSE:
GuiConsoleHandleClose(hWnd);
Result = 0;
break;
case WM_NCDESTROY:
GuiConsoleHandleNcDestroy(hWnd);
Result = 0;
break;
case WM_LBUTTONDOWN:
GuiConsoleLeftMouseDown(hWnd, lParam);

View file

@ -29,12 +29,6 @@ else
CFLAGS_DBG :=
endif
ifeq ($(OPTIMIZED), 1)
CFLAGS_OPT := -O2 -Wno-strict-aliasing
else
CFLAGS_OPT :=
endif
TARGET_CFLAGS =\
$(CFLAGS_DBG) \
-I. \

View file

@ -612,6 +612,15 @@ ifneq ($(TARGET_TYPE),kernel)
endif
endif
#
# Enable Tree-Wide Optimization.
# Protect uncompatible files here with an ifneq
# if needed, until their problems can be found
#
ifeq ($(OPTIMIZED), 1)
MK_CFLAGS += -O2 -Wno-strict-aliasing
MK_CPPFLAGS += -O2 -Wno-strict-aliasing
endif
ifneq ($(TARGET_LIBS),)
MK_LIBS := $(TARGET_LIBS) $(MK_LIBS)