Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-29 02:25:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Revert #16904 and clarify the comment about the race condition.

Browse source 
svn path=/trunk/; revision=16917
This commit is contained in:
Filip Navara 2005-07-31 09:48:12 +00:00
parent 6859ea0c71
commit 5b7fe4e1d2
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
reactos/ntoskrnl/ke/clock.c
View file

@ -305,17 +305,15 @@ KeUpdateRunTime(
/* FIXME: Do DPC rate adjustments */ /* FIXME: Do DPC rate adjustments */
/*
* RACE CONDITION WARNING. If one stays at DISPATCH_LEVEL for a long
* time the DPC routine which checks for quantum end will not be executed
* and decrementing the quantum here would result in overflow.
*/
if (CurrentThread->Quantum < 0)
return;
/* /*
* If we're at end of quantum request software interrupt. The rest * If we're at end of quantum request software interrupt. The rest
* is handled in KiDispatchInterrupt. * is handled in KiDispatchInterrupt.
*
* NOTE: If one stays at DISPATCH_LEVEL for a long time the DPC routine
* which checks for quantum end will not be executed and decrementing
* the quantum here can result in overflow. This is not a problem since
* we don't care about the quantum value anymore after the QuantumEnd
* flag is set.
*/ */
if ((CurrentThread->Quantum -= 3) <= 0) if ((CurrentThread->Quantum -= 3) <= 0)
{ {