Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-20 20:36:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

don't attempt to reference NULL objects in NtIsProcessInJob()

Browse source 
svn path=/trunk/; revision=11019
This commit is contained in:
Thomas Bluemel 2004-09-23 22:02:39 +00:00
parent b50f152bc1
commit 5b552386bc
1 changed files with 37 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

69
reactos/ntoskrnl/ps/job.c
View file

@ -121,47 +121,50 @@ NtIsProcessInJob(IN HANDLE ProcessHandle,
if(NT_SUCCESS(Status)) if(NT_SUCCESS(Status))
{ {
/* FIXME - make sure the job object doesn't get exchanged or deleted while trying to /* FIXME - make sure the job object doesn't get exchanged or deleted while trying to
reference it, e.g. by locking it somehow... */ reference it, e.g. by locking it somehow until it is referenced... */
PEJOB ProcessJob = Process->Job; PEJOB ProcessJob = Process->Job;
/* reference the object without caring about access rights as it does not necessarily if(ProcessJob != NULL)
have to be accessible from the calling process */
Status = ObReferenceObjectByPointer(ProcessJob,
0,
PsJobType,
KernelMode);
if(NT_SUCCESS(Status))
{ {
if(JobHandle == NULL) /* reference the object without caring about access rights as it does not necessarily
have to be accessible from the calling process */
Status = ObReferenceObjectByPointer(ProcessJob,
0,
PsJobType,
KernelMode);
if(NT_SUCCESS(Status))
{ {
/* simply test whether the process is assigned to a job */ if(JobHandle == NULL)
Status = ((Process->Job != NULL) ? STATUS_PROCESS_IN_JOB : STATUS_PROCESS_NOT_IN_JOB);
}
else if(ProcessJob != NULL)
{
PEJOB JobObject;
/* get the job object and compare the object pointer with the one assigned to the process */
Status = ObReferenceObjectByHandle(JobHandle,
JOB_OBJECT_QUERY,
PsJobType,
PreviousMode,
(PVOID*)&JobObject,
NULL);
if(NT_SUCCESS(Status))
{ {
Status = ((ProcessJob == JobObject) ? STATUS_PROCESS_IN_JOB : STATUS_PROCESS_NOT_IN_JOB); /* simply test whether the process is assigned to a job */
ObDereferenceObject(JobObject); Status = ((ProcessJob != NULL) ? STATUS_PROCESS_IN_JOB : STATUS_PROCESS_NOT_IN_JOB);
} }
} else /* JobHandle != NULL */
else {
{ PEJOB JobObject;
/* the process is not assigned to any job */
Status = STATUS_PROCESS_NOT_IN_JOB;
}
ObDereferenceObject(ProcessJob); /* get the job object and compare the object pointer with the one assigned to the process */
Status = ObReferenceObjectByHandle(JobHandle,
JOB_OBJECT_QUERY,
PsJobType,
PreviousMode,
(PVOID*)&JobObject,
NULL);
if(NT_SUCCESS(Status))
{
Status = ((ProcessJob == JobObject) ? STATUS_PROCESS_IN_JOB : STATUS_PROCESS_NOT_IN_JOB);
ObDereferenceObject(JobObject);
}
}
ObDereferenceObject(ProcessJob);
}
}
else
{
/* the process is not assigned to any job */
Status = STATUS_PROCESS_NOT_IN_JOB;
} }
ObDereferenceObject(Process); ObDereferenceObject(Process);
} }