From 5a30c71e7051b84b89809ea112c627ac02eaa6b4 Mon Sep 17 00:00:00 2001 From: Serge Gautherie Date: Tue, 27 Feb 2024 22:42:54 +0100 Subject: [PATCH] [KILL] main(): Return actual return value and get rid of 'tail' variable, which had wrong type anyway. Also, be strict about parameter number: only 1 PID is supported. --- modules/rosapps/applications/sysutils/kill/kill.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/modules/rosapps/applications/sysutils/kill/kill.c b/modules/rosapps/applications/sysutils/kill/kill.c index 8c32b64c3f5..153cfe3905f 100644 --- a/modules/rosapps/applications/sysutils/kill/kill.c +++ b/modules/rosapps/applications/sysutils/kill/kill.c @@ -63,15 +63,11 @@ ExecuteKill(char *lpPid) int main(int argc, char *argv[]) { - char tail; - DBG_UNREFERENCED_LOCAL_VARIABLE(tail); - - if (argc < 2) + if (argc != 2) { - fprintf(stderr, "Usage: %s PID (Process ID) \n", argv[0]); + fprintf(stderr, "Usage: %s PID (Process ID)\n", argv[0]); return 1; } - tail = ExecuteKill(argv[1]); - return 0; + return ExecuteKill(argv[1]); }