Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-05 05:01:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

[DEVMGR] Ensure clicking on item when opening property sheet (#4196)

Browse source 
Fix a bug related to the device manager, where double-clicking anywhere when an item is already selected opens the property sheet.

CORE-17207
This commit is contained in:
Jesús Sanz del Rey 2021-12-29 16:52:41 +01:00 committed by GitHub
parent dc483bd700
commit 5831427ef9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
dll/win32/devmgr/devmgmt/DeviceView.cpp
View file

@ -124,6 +124,27 @@ CDeviceView::OnSize(
return 0;
}
LRESULT
CDeviceView::OnDoubleClick(
_In_ LPNMHDR NmHdr
)
{
TVHITTESTINFO hitInfo;
HTREEITEM hItem;
GetCursorPos(&hitInfo.pt);
ScreenToClient(m_hTreeView, &hitInfo.pt);
// Check if we are trying to double click an item
hItem = TreeView_HitTest(m_hTreeView, &hitInfo);
if (hItem != NULL && (hitInfo.flags & (TVHT_ONITEM | TVHT_ONITEMICON)))
{
DisplayPropertySheet();
}
return 0;
}
LRESULT
CDeviceView::OnRightClick(
_In_ LPNMHDR NmHdr

4
dll/win32/devmgr/devmgmt/DeviceView.h
View file

@ -45,6 +45,10 @@ public:
_In_ int cy
);
LRESULT OnDoubleClick(
_In_ LPNMHDR NmHdr
);
LRESULT OnRightClick(
_In_ LPNMHDR NmHdr
);

2
dll/win32/devmgr/devmgmt/MainWindow.cpp
View file

@ -515,7 +515,7 @@ CDeviceManager::OnNotify(_In_ LPARAM lParam)
case NM_DBLCLK:
{
m_DeviceView->DisplayPropertySheet();
Ret = m_DeviceView->OnDoubleClick(NmHdr);
break;
}